shirsig / aux-addon

Auction House addOn for Classic (1.13) IMPORTANT: The folder name must be "aux-addon" IMPORTANT: The Vanilla (1.12) version moved here https://github.com/shirsig/aux-addon-vanilla
https://www.curseforge.com/wow/addons/aux
196 stars 42 forks source link

Can't Post Item #228

Closed SecretKosmoNaut closed 5 years ago

SecretKosmoNaut commented 5 years ago

Not sure why, but whenever I click on the item listed in the Post tab, it doesn't work. Where can I find log information to narrow down the root cause so that I can provide it here?

kakkakk commented 5 years ago

Post also does not work for me, before this latest version or after. Deleted all traces of the previous versions from \addons and \wtf before installation.

shirsig commented 5 years ago

Strange, it works fine for me. Maybe you didn't log out before deleting the WTF files? Because then they would just be rewritten from cache.

kakkakk commented 5 years ago

Yup, I'm aware. I can try again. Thanks for getting back to me.

On Sun, Sep 8, 2019 at 10:45 PM shirsig notifications@github.com wrote:

Strange, it works fine for me. Maybe you didn't log out before deleting the WTF files? Because then they would just be rewritten from cache.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shirsig/aux-addon/issues/228?email_source=notifications&email_token=AJB47VXMLB4L4CWXEZ3JKF3QIXIFBA5CNFSM4IUU3PTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GHDNI#issuecomment-529297845, or mute the thread https://github.com/notifications/unsubscribe-auth/AJB47VR66LY3LQEHXGGAWQTQIXIFBANCNFSM4IUU3PTA .

kakkakk commented 5 years ago

Still no-go, fresh install of the addon after aux-addon.lua and it's .bak have been removed. At least one other person posted the same problem as me though :)

On Sun, Sep 8, 2019 at 11:15 PM Vincent Brokop vbrokop@gmail.com wrote:

Yup, I'm aware. I can try again. Thanks for getting back to me.

On Sun, Sep 8, 2019 at 10:45 PM shirsig notifications@github.com wrote:

Strange, it works fine for me. Maybe you didn't log out before deleting the WTF files? Because then they would just be rewritten from cache.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shirsig/aux-addon/issues/228?email_source=notifications&email_token=AJB47VXMLB4L4CWXEZ3JKF3QIXIFBA5CNFSM4IUU3PTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GHDNI#issuecomment-529297845, or mute the thread https://github.com/notifications/unsubscribe-auth/AJB47VR66LY3LQEHXGGAWQTQIXIFBANCNFSM4IUU3PTA .

shirsig commented 5 years ago

Hm, can you enable lua errors and copy here what you get please? /console scriptErrors 1

kakkakk commented 5 years ago

That's the interesting thing, it's not throwing any errors. (I've kept lua errors enabled since classic launch, it's been helpful in identifying a few troublesome addons) But with aux... neither right clicking on an object in my bags, nor dragging an object into the appropriate area on the Post tab works.

On Sun, Sep 8, 2019 at 11:37 PM shirsig notifications@github.com wrote:

Hm, can you enable lua errors and copy here what you get please? /console scriptErrors 1

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shirsig/aux-addon/issues/228?email_source=notifications&email_token=AJB47VXCBAIJKFN2S3ONNRLQIXOI3A5CNFSM4IUU3PTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GJMJQ#issuecomment-529307174, or mute the thread https://github.com/notifications/unsubscribe-auth/AJB47VSQYRSEZJJKPXAOSNLQIXOI3ANCNFSM4IUU3PTA .

shirsig commented 5 years ago

Oh, that's the problem? That's not a bug. Right clicking is not possible so I changed it to alt-click. Not sure if dragging was already removed from the latest vanilla version or of it's broken. Anyway, you can also click the items in the list within aux, which is the intended way to do it.

kakkakk commented 5 years ago

Thank you for taking the time to clarify! I always just right clicked from my bags while using the addon on private vanilla servers. I will alt click from now on or use the list built into the addon. Cheers!

On Sun, Sep 8, 2019 at 11:52 PM shirsig notifications@github.com wrote:

Oh, that's the problem, that's not a bug. Right clicking is not possible so I changed it to alt-click. Not sure if dragging was already removed from the latest vanilla version or of it's broken. Anyway, you can also click the items in the list within aux, which is the intended way to do it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shirsig/aux-addon/issues/228?email_source=notifications&email_token=AJB47VTPF73U2EPBLS2UET3QIXQBTA5CNFSM4IUU3PTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GKDRI#issuecomment-529310149, or mute the thread https://github.com/notifications/unsubscribe-auth/AJB47VWICONNUF4OS6FD4Y3QIXQBTANCNFSM4IUU3PTA .

SecretKosmoNaut commented 5 years ago

Here's the error I receive, it wasn't showing an error before but now it's popping up in a GUI box:

Date: 2019-09-11 14:58:51 ID: 1 Error occured in: Global Count: 1 Message: ..\AddOns\aux-addon\util\money.lua line 62: attempt to compare nil with number Debug: aux-addon\util\money.lua:62: to_string() aux-addon\tabs\post\core.lua:400: update_item() aux-addon\tabs\post\frame.lua:63: aux-addon\tabs\post\frame.lua:61 Locals: money = nil pad = true trim = nil color = nil no_color = true (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to compare nil with number" T =

{ } aux =
{ }

AddOns: Swatter, v8.2.6377 (SwimmingSeadragon) AccountantClassic, vv2.11.08.11302 AucAdvanced, v8.2.6385 (SwimmingSeadragon) AucFilterBasic, v8.2.6364 (SwimmingSeadragon) AucScanData, v8.2.6365 (SwimmingSeadragon) AucStatHistogram, v8.2.6366 (SwimmingSeadragon) AucStatiLevel, v8.2.6370 (SwimmingSeadragon) AucStatPurchased, v8.2.6367 (SwimmingSeadragon) AucStatSimple, v8.2.6368 (SwimmingSeadragon) AucStatStdDev, v8.2.6369 (SwimmingSeadragon) AucUtilFixAH, v8.2.6371 (SwimmingSeadragon) AutoLootPlus, v2.0.0-11302 auxaddon, v0.2.2 BagBrother, v Bagnon, v8.2.9 Bartender4, v4.8.7 BeanCounter, v8.2.6381 (SwimmingSeadragon) Enchantrix, v8.2.6392 (SwimmingSeadragon) GatherMate2, v1.45 Informant, v8.2.6374 (SwimmingSeadragon) Questie, v4.0.18 BETA SlideBar, v8.2.6375 (SwimmingSeadragon) Stubby, v8.2.6376 (SwimmingSeadragon) BlizRuntimeLib_enUS v1.13.2.11302 (ck=38b)

helllllpppp commented 5 years ago

Also having the same problem with a specific item.

Message: Interface\AddOns\aux-addon\util\money.lua:62: attempt to compare nil with number Time: Thu Sep 12 00:27:05 2019 Count: 5 Stack: Interface\AddOns\aux-addon\util\money.lua:62: attempt to compare nil with number Interface\AddOns\aux-addon\util\money.lua:62: in function to_string' Interface\AddOns\aux-addon\tabs\post\core.lua:401: in functionupdate_item' Interface\AddOns\aux-addon\tabs\post\frame.lua:63: in function <Interface\AddOns\aux-addon\tabs\post\frame.lua:61>

Locals: money = nil pad = true trim = nil color = nil no_color = true (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to compare nil with number" T =

{ } aux =
{ }

Deniability commented 5 years ago

Am getting the same as above specifically with silk cloth, when attempting to list.

Alt-Clicking results in this error as well

Message: Interface\AddOns\aux-addon\util\money.lua:62: attempt to compare nil with number Time: Thu Sep 12 04:30:08 2019 Count: 3 Stack: Interface\AddOns\aux-addon\util\money.lua:62: attempt to compare nil with number Interface\AddOns\aux-addon\util\money.lua:62: in function to_string' Interface\AddOns\aux-addon\tabs\post\core.lua:401: in functionupdate_item' Interface\AddOns\aux-addon\tabs\post\core.lua:183: in function select_item' Interface\AddOns\aux-addon\tabs\post\core.lua:86: in functionUSE_ITEM' Interface\AddOns\aux-addon\core\shortcut.lua:26: in function HandleModifiedItemClick' Interface\FrameXML\ContainerFrame.lua:1247: in functionContainerFrameItemButton_OnModifiedClick'

Locals: money = nil pad = true trim = nil color = nil no_color = true (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = nil (*temporary) = "attempt to compare nil with number" T =

{ } aux =
{ }

shirsig commented 5 years ago

These look like savedvariable issues. Try deleting them (remember to log out first)

SecretKosmoNaut commented 5 years ago

Yeah... I don't want to affect other addons by deleting my variables folder. I've clean installed this twice and it keeps reverting to this same error. For now, I have to use your addon in conjunction with Auctioneer which is annoying but as long as this is an issue it's what I have to do to post items.......

shirsig commented 5 years ago

You don't need to delete other addons' savedvariables, only aux'.

SecretKosmoNaut commented 5 years ago

I'll try that, see if it works. Thank you.

shirsig commented 5 years ago

It's a single file I think at WTF/account/{youraccountname}/savedvariables/aux-addon.lua but cant check right now im on my phone. Make sure youre logged out when u delete it or itll be rewritten from memory.

tyggyr commented 5 years ago

I believe the fix is in aux-addon\util\money.lua

function M.to_string(money, pad, trim, color, no_color)
+   if not money then
+       money = 0
+   end

Lua errors were telling me that money was nil. Sorry I have no diff for this.

shirsig commented 5 years ago

It's not really a fix, it's kind of dangerous. The money there should not be 0, that's the real problem. Strange that only a few people have this issue. For some it will definitely be a savedvariables issue, but since it didn't fix it for everyone dunno ... Could you try disabling all other addons to see if it's an addon conflict?

tyggyr commented 5 years ago

I'll back the change out and then when it reproduces I'll do the disable others; I expect that it won't help since nuking the saved variables "fixed" it for me last time... temporarily.

On Fri, Sep 13, 2019, 11:45 PM shirsig notifications@github.com wrote:

It's not really a fix, it's kind of dangerous. The money there should not be 0, that's the real problem. Strange that only a few people have this issue. For some it will definitely be a savedvariables issue, but since it didn't fix it for everyone dunno ... Could you try to disable all other addons to see if it's an addon conflict?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/shirsig/aux-addon/issues/228?email_source=notifications&email_token=AIL7AL7UIDQBR2JOJQRTUVTQJSCAPA5CNFSM4IUU3PTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WVZ5Y#issuecomment-531455223, or mute the thread https://github.com/notifications/unsubscribe-auth/AIL7AL2XXPTUQAMZR77BEETQJSCAPANCNFSM4IUU3PTA .

SecretKosmoNaut commented 5 years ago

Deleting the file you mentioned previously worked. Should I leave this ticket open for reference?

tyggyr commented 5 years ago

Disabling all other addons, the problem still occurs.

tyggyr commented 5 years ago

I'll note that money isn't zero, it's nil. I'm definitely not a lua expert but I think there's a difference.

shirsig commented 5 years ago

With the newest version try /aux clear post or /aux clear item cache and /run ReloadUI()

GuerraReturns commented 5 years ago

TEMPORARY FIX FOR ALL PEOPLE HAVE THIS PROBLEM: Without lost Saves

Close WOW. <- IMPORTANT

Go to your WOW Folder -> WTF -> Account -> accountnumer -> SavedVariables

Cancel the file "aux-addon.lua.bak"

Download Notepad ++ (is the best) In Notepad ++ (on top) press "lenguages" -> L -> Lua

Find you're bugged ID. In my case, i can't post Wool Cloth

Write on google : "itemyoucan'tpost ID WOW" (in my case: Wool CLoth id wow) Open the first link, is 99% wowhead (in my case: https://classic.wowhead.com/item=2592/wool-cloth)

You can see the id inside the Link (in my case: 2592)

Go to Notepad:

Go to the top of the script You have something like this:

["faction"] = {
    ["Flamelash|Alliance"] = {
        ["post"] = {

Now , you have a lot of string like this:

            ["6331:0"] = "3#25075#65090#0"

Find you're ID

            ["2592:0"] = "mypriceu.u"

Cancel the string

BEFORE: ["6331:0"] = "3#25075#65090#0", ["2592:0"] = "3#0.001#150#0", <- BUGGED ["13043:0"] = "3#59000#80000#0",

AFTER: ["6331:0"] = "3#25075#65090#0", ["13043:0"] = "3#59000#80000#0",

Save changes. (File -> Save)

Close Notepad

Start WOW

Enjoy, now you can post