shirsig / aux-addon

Auction House addOn for Classic (1.13) IMPORTANT: The folder name must be "aux-addon" IMPORTANT: The Vanilla (1.12) version moved here https://github.com/shirsig/aux-addon-vanilla
https://www.curseforge.com/wow/addons/aux
196 stars 42 forks source link

Regarding /aux scan #244

Closed KevinTyrrell closed 4 years ago

KevinTyrrell commented 5 years ago

Actually, I did a test of the following: 1) I wrote down the price of four items in my bags. Copper Ore, Greater Healing Potion, Swiftness Potion, and Silk Cloth. 2) I typed /aux scan 3) I looked back at the tooltips after the scan completed (again, no message appears that the scan finished, but my framerate went back to normal after 30 seconds). All the items showed the same prices (very unlikely, as prices are likely to have changed very slightly since the last scan days ago)/ 4) I typed each items name into the search bar, waited for the scan for that item to complete. After scanning all four items I looked back at the tooltips and they still show the same price. 5) I reloaded my UI, still no change with the tooltips.

Essentially I'm not sure if this means that scanning is completely broken or not or if its just the tooltips?

Thank you for your time.

shirsig commented 5 years ago

/aux scan is way faster but it's only for the history currently. There is a notification in the chat when it begins and when it completes. It will definitely be added to the UI but I don't know where/how yet. Empty queries are not using the fast scan setting because fast scans can only be done every 15 minutes and aux does output an error message if you try it again before it's ready. A scan does not immediately affect the historical value (except on the first day). Only at the end of the day a new daily value is generated which affects the median. Aux' daily historical values are based on the minimum buyout so it doesn't make a difference how many times you scan the same auction. It's impossible to say with certainty how many times an auction has been seen because there's no such thing as a unique id for auctions.

KevinTyrrell commented 5 years ago

it's only for the history currently.

Can you explain exactly what you mean by this? To the user we don't see any kind of history for a specific item, only the market value (unless there's some UI that I don't know about). It's not immediately clear what differentiates /aux scan from an empty query. They both seem like they lead to the same result (ignoring the 15 minute cooldown and long scan times from empty query).

It's impossible to say with certainty how many times an auction has been seen because there's no such thing as a unique id for auctions.

Even without ID's, what about if the 'seen' value was only incremented when scans are 24 hours apart. Since all auctions leave the auction house after 24 hours, that means 24 hours later every single auction is unique from your previous scan (and can be counted to a total seen value). Not sure if this is a useless feature or not though. It's quite helpful for items which are not commonly on the auction house.

shirsig commented 5 years ago

The difference is that you can't browse the results of /aux scan. As for the seen value, not sure if it's worth the added complexity. I've thought about such solutions before and I might consider adding it at some point but my time is limited and there are many things with higher priority.

KevinTyrrell commented 4 years ago

Minor reply that the Scan button is a wonderful feature. Thank you!