search

shirsig / aux-addon

Auction House addOn for Classic (1.13) IMPORTANT: The folder name must be "aux-addon" IMPORTANT: The Vanilla (1.12) version moved here https://github.com/shirsig/aux-addon-vanilla
https://www.curseforge.com/wow/addons/aux
196 stars 42 forks source link

Item quality on recent searches #277

Closed spidor closed 4 years ago

spidor commented 5 years ago

Since the last patch item quality in the recent searches messed up, and shows everything (almost) as legendary quality.

aux_scr

shirsig commented 5 years ago

Hey. That it is the same color as legendary is coincidental. Orange is just the default color for all operators. This happens when there is no item data for the items in the query. I guess you have deleted your savedvariables recently or used /aux clear item data or something? Eventually the item data should all be back but this can take like an hour of playtime or more I guess.

spidor commented 5 years ago

Interesting, because I'm sure there were items on the AH from the recent searches list. It has been like this since the last update, that is why I thought it was changed in the patch.

As you can see in this example the item is available on the AH, yet it stays orange. There is something else going on here.

aux_scr

Is there any way to reset the recent searches?

shirsig commented 5 years ago

I think the auction api does not automatically fetch the data for the iteminfo api. If you called /run GetItemInfo(id) with the id of one of these items then after a second do another search then the item should have the correct color. Or you can wait for aux to fetch it which may take a while because it starts with item id 1 and goes up to 15k or something and it is quite throttled.

spidor commented 5 years ago

Thanks for the tip. Unfortunately it didn't work. I also tried to totally reinstall the addon. Deleted my saved variables, restored them, didn't work either. It is not a big deal, but helps to overview the items easier. Also I noticed that the auto-completion is working a little weird. It does not give me suggestions, and if I remember correctly it did before. Could be those two issues connected? Anyway, thanks for your help.

shirsig commented 5 years ago

Are you sure? Like I said, it may take a while for aux to scan the item data again. If it's a high item id possibly hours. And you have to be careful not to kill the client but exit normally or savedvariables will never be saved.

Also it will never fix the existing recent searches but new searches should create a correct label.

spidor commented 5 years ago

Should I just let Aux run while the AH window is open or is there anything else I should do?

shirsig commented 5 years ago

You don't need to be at the ah.

E1ila commented 5 years ago

Is there a way to know aux is still querying item info, or has finished?

spidor commented 5 years ago

Is there a way to know aux is still querying item info, or has finished?

That's a good question. Over the weekend I was online for hours continuously and logged out properly every time. Yet the issue is still exists.

shirsig commented 5 years ago

No. It shouldn't really affect you besides autocompletion and displaying of the queries though and it doesn't require any action from you so you can just keep playing normally and after a few days all items should be fetched.

Improving the fetch time is the next thing on my todo list for aux, but it's gonna be difficult as I have to throttle it enough that people aren't disconnected and I think there are different thresholds for different regions.

shirsig commented 5 years ago

Is there a way to know aux is still querying item info, or has finished?

That's a good question. Over the weekend I was online for hours continuously and logged out properly every time. Yet the issue is still exists.

I'll check it out, maybe there's also a bug.

spidor commented 5 years ago

I'll check it out, maybe there's also a bug.

Thank you very much :)

shirsig commented 5 years ago

Indeed there was a bug. Fixed it now and it's working like before. Still planning to optimize it as it is pretty slow.

Edit: faster item scanning, only on github for now, might cause lags or disconnects.

spidor commented 5 years ago

Indeed there was a bug. Fixed it now and it's working like before. Still planning to optimize it as it is pretty slow.

Edit: faster item scanning, only on github for now, might cause lags or disconnects.

Awesome, thank you for checking and fixing it :) I'll give the github version a try, and let you know my results.

spidor commented 5 years ago

It is working for me now. Interestingly I thought it would start querying the items by itemID lower to higher, but it seems not. Anyway as you can see the Arcanite Bar is now queryed properly, so I quess it just need more time to finish every item :)

WoWScrnShot_112019_095806

I'll be using aux more in the next few days. Do you want me to report my results?

shirsig commented 5 years ago

Yeah, please.

spidor commented 5 years ago

Yeah, please.

It's working as it worked before the bug report. Items are queried. I got a few disconnects, but really just 2-3 times.

shirsig commented 4 years ago

These disconnects were soon after logging in or could also have been for other reasons? Because with this speed the scanning shouldn't take more than a few minutes.

spidor commented 4 years ago

No, disconnects seems to be random, not short after logging in. I've been online for few hours, and there are still items that are not queried, so it takes more than just a few minutes. Not sure how many items are queried thought, but most of my recent searches are.

shirsig commented 4 years ago

I think they they weren't working was a different bug. It really should've been finished within 10 minutes or so at that speed. Anyway, I still added some throttling to be safe and put it on curse now.