search

shirsig / aux-addon

Auction House addOn for Classic (1.13) IMPORTANT: The folder name must be "aux-addon" IMPORTANT: The Vanilla (1.12) version moved here https://github.com/shirsig/aux-addon-vanilla
https://www.curseforge.com/wow/addons/aux
196 stars 42 forks source link

add support for the arity setting for logical operators in the filter builder #339

Open Artur91425 opened 2 years ago

Artur91425 commented 2 years ago

https://youtu.be/4C5JOkfY-mA

Artur91425 commented 2 years ago

The only thing I'm not sure that I changed the code everywhere. See, please, so that there are no extra lines that are no longer needed at this implementation. For example, these lines are confused me: https://github.com/shirsig/aux-addon/blob/30c39e1d2f528e14c84d1621c1a6ef50e33b04a4/util/filter.lua#L335-L337 and https://github.com/shirsig/aux-addon/blob/30c39e1d2f528e14c84d1621c1a6ef50e33b04a4/util/filter.lua#L367-L369 It seems to me that since the operators are added to the filter_util.filters table, it is no longer necessary to add separately in suggestions table, but I'm not sure about it.

Artur91425 commented 2 years ago

oops, sorry, I forgot to delete my localization code

Artur91425 commented 2 years ago

I came up with how to save the order of displaying filters and even set and change it at any desired moment. I will make a commit a little later.

Done :-)