search

shirsig / aux-addon

Auction House addOn for Classic (1.13) IMPORTANT: The folder name must be "aux-addon" IMPORTANT: The Vanilla (1.12) version moved here https://github.com/shirsig/aux-addon-vanilla
https://www.curseforge.com/wow/addons/aux
196 stars 42 forks source link

Bugfix/wotlk classic p2 fixes #358

Closed Jakobud closed 1 year ago

Edrenas commented 1 year ago

This has fixed aux for me, thanks!

shirsig commented 1 year ago

Thanks a lot, I'm swamped with work at the moment, really appreciate the help. One thing I noticed, editbox:SetMaxLetters(255) where previously nil was passed - I assume the meaning of nil was unlimited, so this could be too restrictive now in some cases. should probably be the largest number possible by default if unlimited is no longer an option.

Jakobud commented 1 year ago

So the number can no longer be nil . According to this:

https://wowpedia.fandom.com/wiki/API_EditBox_SetMaxLetters

255 is the max amount allowed.

shirsig commented 1 year ago

Hm, I think the main search box is using that component though, that could be a problem with longer filters. Anyway, will look at that later, merging now, thanks.

Jakobud commented 1 year ago

Okay I'm not sure if that 255 limit is something that was recently added or not. Definitely a lot of arguments in the API became non-nilable with the WOTLK Phase 2 patch. Probably filtering down from retail.

shirsig commented 1 year ago

I was able to get back the unlimited-default behavior by just removing the call altogether. Back when I first implemented it I think there was an error when using the editbox without having set it, but that doesn't seem to be the case anymore.