search

shirsig / ccc

CC & DR timers for Classic (1.13) IMPORTANT: The folder name must be "ccc"
https://www.curseforge.com/wow/addons/ccc
27 stars 7 forks source link

Rogues and Ruthlessness #11

Closed Voidmenull closed 7 years ago

Voidmenull commented 7 years ago

the spell http://db.vanillagaming.org/?spell=14161

does trigger the UNIT_COMBAT (COMBO variable becomes to 1 point) event and therefor you get wrong timers(if proc) for Rupture and Kidney Shot :/

im not sure how to solv this...prob. add UNIT_COMBAT() in the spellhook function instead on event...

shirsig commented 7 years ago

Yeah, I've done this for my new version of aurae. However, if you use combat log events there probably isn't a simple solution.

shirsig commented 7 years ago

Well, I guess you could set it where the entry in "pending" is created. For other player's spells it won't work anyway and I guess all combo point spells are direct casts so this would probably work.

Still, there would almost certainly be some bad corner cases.

Voidmenull commented 7 years ago

works so far, can be closed if you fixed it in the main addon :)