search

shirsig / ccc

CC & DR timers for Classic (1.13) IMPORTANT: The folder name must be "ccc"
https://www.curseforge.com/wow/addons/ccc
27 stars 7 forks source link

Frostbolt timing broken #32

Closed WayOfTheRoad closed 5 years ago

WayOfTheRoad commented 5 years ago

My rank 9 frostbolt's slow lasts 9 seconds. CCC shows it as 12 seconds and it messes up further if I reapply the slow in that extra 3 seconds after the first has faded, while it's still counting down.

shirsig commented 5 years ago

Strange,, seems like it applies the 3 second talent bonus even though I assume you don't have it? Or is the base duration wrong?

WayOfTheRoad commented 5 years ago

Correct, I don't have the talent Permafrost. The 12 seconds would be correct if I had 3/3 Permafrost.

shirsig commented 5 years ago

Ok, I think it's probably looking at the wrong talent for the bonus. Will try to fix it after work.

WayOfTheRoad commented 5 years ago

Thank you very much!

shirsig commented 5 years ago

I committed the fix. Does it work now? (It's not on curse yet)

WayOfTheRoad commented 5 years ago

It is still adding 3 seconds to Frostbolt and Cone of Cold. They can break and stop tracking altogether if I reapply the slow while the extra 3 seconds is still counting down. If it doesn't break, it also does not start timing the new application of the the slow -- it will finish counting down the 3 seconds.

WayOfTheRoad commented 5 years ago

Also, I can't tell you under which conditions, but Frost Nova fails to track/time sometimes.

shirsig commented 5 years ago

Oh, I missed some places. What about now? For frost nova please open a separate bug.

WayOfTheRoad commented 5 years ago

Seems to work now!