shirsig / ccc

CC & DR timers for Classic (1.13) IMPORTANT: The folder name must be "ccc"
https://www.curseforge.com/wow/addons/ccc
28 stars 7 forks source link

Hunter Spells #4

Closed Voidmenull closed 7 years ago

Voidmenull commented 7 years ago

It seems like aurae doesnt support a single hunter spell... Concussive Shot, Serpent Sting, Viper Sting, Volley, all Traps etc

shirsig commented 7 years ago

Some are definitely supported. I see serpent sting all the time at least. Not the others because I only play 19 pvp but at least viper sting is listed as a debuff so it should work too. Traps will only work in pvp. Volley isn't even a debuff, is it?

shirsig commented 7 years ago

Could be that viper and serpent sting also don't work in pve because of the delay, if so that should be fixed now and I've added concussive shot.

Voidmenull commented 7 years ago

wing clip still doesnt work (at least in pve)

Voidmenull commented 7 years ago

wyvern sting also

shirsig commented 7 years ago

Maybe they work now. By the way, do all stings have a delay between cast and application?

Voidmenull commented 7 years ago

its super strange, the stings react only when i cast them 2+ times and they react without any delay

shirsig commented 7 years ago

are you talking about aurae now? I was talking about game mechanics (fly time of the projectile)

Voidmenull commented 7 years ago

ah, yea i was talking about aurea...but the projectile has also a fly-delay, yes

Voidmenull commented 7 years ago

seems like it works flawless if im close to a target

shirsig commented 7 years ago

yeah, I need to add the fly time for the pve mechanic or it won't be applied. I've made it one second now, guess that's not enough then if you're too far? or are you not using that version yet

Voidmenull commented 7 years ago

let me update quick

Voidmenull commented 7 years ago

its working only from a rly rly short range, not useable like that :/

shirsig commented 7 years ago

the same for all? what's the fly time? It works fine for me for frostbolt and others

Voidmenull commented 7 years ago

idk what the fly time is, but def. shorter then on the mage (where it works), its the same for all spells...

shirsig commented 7 years ago

Probably now, somehow sting got autocompleted to string (i assume it was already working for concussive shot?)

Voidmenull commented 7 years ago

still the same :/ concussive has also only low range :/

shirsig commented 7 years ago

the top of your data/actions.lua looks like this? aurae_DELAYS = { ["Fireball"] = 1, ["Frostbolt"] = 1, ["Concussive Shot"] = 1, ["Viper Sting"] = 1, ["Serpent Sting"] = 1, ["Wyvern Sting"] = 1, }

Voidmenull commented 7 years ago

yes ofc :)

shirsig commented 7 years ago

no idea then, guess will have to wait till nost brings back my 19 hunter twink to test this xD

Voidmenull commented 7 years ago

alright :) maybe its my emulator that doing something wrong (invisible cast time line)

Voidmenull commented 7 years ago

the problem is somewhere in the delay calculation line 338: pending[effect] = {target=target, time=GetTime() + (aurae_RANKS[effect] and aurae_DELAYS[effect] or 0)}

for my mage i get Print(pending[effect].time - GetTime()) 1 second, for the hunter 0 seconds...

Voidmenull commented 7 years ago

aurae_RANKS[effect] is not a part of actions.lua for the hunter and therefore nil :)

shirsig commented 7 years ago

what?

Voidmenull commented 7 years ago

the delay from (aurae_RANKS[effect] and aurae_DELAYS[effect] or 0) is always 0 because there is no aurae_RANKS[effect] for the hunter shots

Voidmenull commented 7 years ago

http://i.imgur.com/5jgr9Ku.png

here an example(for serpent sting) you have to add to make it work... otherwise line 338 will calculate always GetTime() + 0 seconds as delay: pending[effect] = {target=target, time=GetTime() + (aurae_RANKS[effect] and aurae_DELAYS[effect] or 0)} since aurae_RANKS[effect] is nil

shirsig commented 7 years ago

Ah yeah that conditional was an artifact from when delay was a field in the ranks entries that i forgot to remove. Now it should work, thanks.

Voidmenull commented 7 years ago

fixed, ty :)