search

shirsig / unitscan

Lightweight npcscan clone for classic (1.13). IMPORTANT: The folder name must be "unitscan". IMPORTANT: For vanilla (1.12) use this instead: https://github.com/shirsig/unitscan-vanilla
https://www.curseforge.com/wow/addons/unitscan
30 stars 26 forks source link

[Not an issue] This should be included... #2

Closed Seminko closed 6 years ago

Seminko commented 6 years ago

Hey, not sure why but noticed that the addon doesn't come with any rares "pre-packed"... so I did it myself. Feel free to include that in the addon. And feel free to mention me ;) npcscan.txt

jackajack commented 6 years ago

Thanks mate I'm using this, do you have same kind of problems as I do here? https://github.com/shirsig/npcscan/issues/3

shirsig commented 6 years ago

Does not work well with scanning in vanilla.

Seminko commented 6 years ago

What do you mean it does not work well? Well what I found out is that the names need to be in all caps for some reason, otherwise it won't work, but if they are the list works like a charm.

Also, would be great if every session the list would get updated again (if selected in the settings).

shirsig commented 6 years ago

Look at the other issue linked byjackjack

Seminko commented 6 years ago

It did that when I used the list as is. When I use the list in all caps, it works properly. No constant targetting, proper sound and popup alert...

shirsig commented 6 years ago

I just assumed from the bug that you had a permanent list. The limitation inherent to this scanning is that the name has to be removed from the list once it's detected.

I think it would be useful to be able to manage the names in an easier way, like having a gui listing where they don't get removed but deactivated and you can reactivate them or something, maybe I'll do that sometime, but making a gui is always a bother. It would be nice to not have to retype something all the time that you're camping.

In a rare list I don't see much of a point in vanilla as only nazjak and two hunter pets are interesting, the rest would just be annoying, and the addon doesn't just scan for rares anyway. I mostly use it for players/questmobs.

There's further another issue that the addon cannot tell apart npcs from players/pets before targeting them so if you have a list with many names you'll constantly get something like an alert for a pet named "lupos".

Finally it will also impact performance if you have a long list.