search

shirsig / unitscan

Lightweight npcscan clone for classic (1.13). IMPORTANT: The folder name must be "unitscan". IMPORTANT: For vanilla (1.12) use this instead: https://github.com/shirsig/unitscan-vanilla
https://www.curseforge.com/wow/addons/unitscan
30 stars 26 forks source link

Low frame rate with WOLK Patch 3.4.2 #26

Closed cwland closed 1 year ago

cwland commented 1 year ago

When this add-on is enabled with the latest patch, the frame rate drops so low the game is unplayable.

shirsig commented 1 year ago

Interestingly it was turning off the sound through the cvar interface for the attempted targeting that was causing the slowdown. I'm not sure now if that was even ever needed for classic (in vanilla/1.12.1 it was needed because it was actually targeting, not just attempting to target, which was causing targeting sounds) so I've just removed it and I haven't noticed any issues.

kriminy commented 1 year ago

This issue is also present in the new Classic Era PTR (toc 1.14.4). I'm not sure how to fix this, but I'll try to search and comment it out.

edit: I commented out lines 40, 41, and 43 of unitscan.lua. Seems to work. Thank you so much!

shirsig commented 1 year ago

Thanks for pointing that out. I applied the same fix to the classic era version.