shirsig / unitscan

Lightweight npcscan clone for classic (1.13). IMPORTANT: The folder name must be "unitscan". IMPORTANT: For vanilla (1.12) use this instead: https://github.com/shirsig/unitscan-vanilla
https://www.curseforge.com/wow/addons/unitscan
30 stars 26 forks source link

Problem with adding entries after last update #30

Open Flowy opened 9 months ago

Flowy commented 9 months ago

After last update, I started getting this error

1452x invalid key to 'next' [string "=[C]"]: in functionnext' [string "@unitscan/unitscan.lua"]:270: in function `UPDATE' [string "@unitscan/unitscan.lua"]:3: in function <unitscan/unitscan.lua:3>

Locals: (temporary) =

{ LIL TIMMY = true GOBBLER = true SEWER BEAST = true GAZELE = true } (temporary) = "MOTHER FANG"`

Its triggered when I'm changing zones, because I have WA that changes scanned names based on zone. The problem does not happen always, it depends on how many names there is to add.

Would it be possible to change the iteration so its not affected by latest updates, or use one that accepts removing/adding entries?

Also other option would be to allow public API, that would prevent the iteration from failing. Expected functions would be to read currently tracked, add, remove, bonus function would be to add listener for when the name is triggered, and option to disable default announcement (sounds and visuals)

mentioned WA is this https://wago.io/Pyfd62ceG , its using direct table unitscan_targets as thats only public entry that you provide, it is triggered when changing zones, does not fail every time, but quite often, after fail unitscan keeps failing until reload or the original entries are added

shirsig commented 9 months ago

Is it fixed now?

Flowy commented 9 months ago

Yes, seems to not throw errors now, thank you