Closed ptmerz closed 3 years ago
- [ ] Rename bs_seed to something more descriptive
Consider doing the same for the bootstrapping related quantities in ensemble.py
(to avoid merge conflicts, wait until #85 was merged - or simply work off that branch).
In #86, @mattwthompson made some good comments. We should
This was added as a prerequisite of #89, because the tests introduced in #89 won't pass without having the bootstrap seed properly used. Introducing #89 first would require to change the test to ignore the output affected by the bootstrapping (such that it still passes CI), and then change them back when introducing this. In hindsight, this might have been a better way to go about it, but it seems like overkill now. Testing locally, I can confirm, however, that #89 fails without the current change.
We could still add additional tests as a follow-up to #89. We'll have to be careful in deciding what we want to test using end-to-end tests, however - they are relatively slow, so anything that can be unit-tested rather than regression tested would be better.
I'd agree. Maybe a follow-up?
_Originally posted by @ptmerz in https://github.com/shirtsgroup/physical_validation/issues/86#issuecomment-769624996_