search

shish / blender-ikea-browser

Import 3D models from ikea.com into your scene!
20 stars 1 forks source link

Only first thumb is shown #5

Closed tin2tin closed 3 months ago

tin2tin commented 3 months ago

Very cool project. I didn't know that there is an API for IKEA furniture.

You properly already know, but currently, only the first thumb is loaded: image

For running it in Blender 4.3 "Allow Online Access" to be checked: image

For ease of use maybe you could add Install/Uninstall Dependencies button in the Add-on preferences(I have buttons like that in a couple of my add-ons)? Or you could point users to use this add-on for installing the dependency module: https://github.com/amb/blender_pip

shish commented 3 months ago

You properly already know, but currently, only the first thumb is loaded

I've seen this, but can't figure out why yet - specifically the first time a set of search results are shown, all of the thumbnails are downloaded into the cache, but only the first is displayed. If you then make the same search again, all the thumbnails appear to be loaded correctly...

For ease of use maybe you could add Install/Uninstall Dependencies button in the Add-on preferences

With the new Extension system in 4.2, this shouldn't be necessary -- the .zip file distributed via extensions.blender.org should have all the dependencies bundled into it

(If you mean for development, for people who are running the code from github... I don't actually know that workflow myself -- right now, every time I update the code, I am building a whole new .zip file and reinstalling it :sweat_smile: )

tin2tin commented 3 months ago

@shish

Great, now the thumbnails are working!

For running it in Blender 4.3 "Allow Online Access" to be checked Same thing for 4.2. When running the add-on, you could check if use_online_access is check-marked, and if not, encourage users to checkmark it (doing it automatically, is properly not correct behavior).

For ease of use maybe you could add Install/Uninstall Dependencies button in the Add-on preferences

With the new Extension system in 4.2, this shouldn't be necessary -- the .zip file distributed via extensions.blender.org should have all the dependencies bundled into it

It currently doesn't automatically install the dep. when installing the add-on. But if you plan on including the add-on into the Extensions lib, it might be a different story (I haven't been down that route yet).

I don't actually know that workflow myself -- right now, every time I update the code, I am building a whole new .zip file and reinstalling it

If you're using an external IDE, you could either edit the installed add-on files directly in their installed location(or use sym-links), save the files in the IDE and then while keeping Blender open hit F3, and search "Reload Scripts", and when executing this, your add-on will update. For quick edits, you can enable Preferences > Interface > Developer Extras which adds Edit Source in the right-click menu, and you can then click on a button in your add-on and open the script in the Blender Text Editor, do the edits, save the script, and hit f3 and "Reload Scripts".

shish commented 3 months ago

It currently doesn't automatically install the dep. when installing the add-on

That is weird, it seems to be working for me (as in, I take a vanilla 4.2 install, prefs -> add-ons -> install from .zip -> select ikea_browser.zip -> it all seems to work with no extra steps)

If you're using an external IDE [...]

That is excellent to know, thank you, that'll speed up my development cycle quite considerably :D