search

shishirbychapur / pe

0 stars 0 forks source link

Adding a Patient UML Diagram Issue #12

Open shishirbychapur opened 10 months ago

shishirbychapur commented 10 months ago

image.png

Doesnt reflect the new Person object being created in the add command parser class.

    public AddCommand parse(String args) throws ParseException {

        Person person = new Person(name, nric, email, phone, gender, age, bloodType, allergies,
                new UniqueRecordList(), new UniqueAppointmentList(), false);

        return new AddCommand(person);
    }
soc-se-bot commented 10 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

New Record object being created inside the AddRecordCommandParser is not reflected in UML diagram.

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

A new record is being created inside the AddRecordCommandParser class but its not shown in the diagram.

Record record = new Record(dateTime, conditions, medications, null, index.getZeroBased());

[original: nus-cs2103-AY2324S1/pe-interim#2389] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

While valid, our team chose to omit the object creation as we wanted to keep the sequence diagram at a high level, keeping it simple and focusing on the interactions between the various entities in the system. We felt that the inclusion of the new objects did not value add anything to the understanding of the diagram. In addition, in can be inferred that a new object is created from the add commands. However, this might be subjective and hence we chose to respond with NotInScope.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** Same reason as the `New Record object being created inside the AddRecordCommandParser is not reflected in UML diagram.` issue!