search

shishkin / astro-pagefind

Astro integration for Pagefind static site search.
MIT License
267 stars 15 forks source link

fix(dependency): Adds Astro 3.0 to astro peer dependency #44

Closed scottaw66 closed 1 year ago

scottaw66 commented 1 year ago

Fixes astro peer dependency issue with Astro 3.0 versions.

npm ERR! Found: astro@3.0.7 npm ERR! node_modules/astro npm ERR! astro@"^3.0.7" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer astro@"^2.0.4" from astro-pagefind@1.2.3 npm ERR! node_modules/astro-pagefind npm ERR! astro-pagefind@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

diomed commented 1 year ago

@shishkin please merge this as soon as possible

shishkin commented 1 year ago

Thanks for the PR, @scottaw66. I understand that it might be a blocker for some users. However I don't want to just "declare" compatibility without actually making astro-pagefind work on Astro 3. I have renovate bot that does updates from time to time and the Astro 3 branch has some issues at the moment. I will look into it some time or maybe the issue will be just fixed upstream with Astro (the 3 major update was not very smooth so far).

Robin-Wils commented 1 year ago

Hi,

Is there a temporary workaround for Astro 3 users who dare to live on the edge?

I have tried npm install https://github.com/scottaw66/astro-pagefind#main without success.