search

shishkin / astro-pagefind

Astro integration for Pagefind static site search.
MIT License
266 stars 15 forks source link

Add ready state condition in Search.astro #72

Closed ShivamJoker closed 8 months ago

ShivamJoker commented 8 months ago

Ref #71

shishkin commented 8 months ago

Thanks for providing the fix.

I've never used readyState before and would like to understand it better. Would it work with astro view transitions?

ShivamJoker commented 8 months ago

Yes, it should work fine. You can test it to ensure it works.

shishkin commented 8 months ago

Well, I tested it and it didn't work. UI didn't initialize after a view transition. It seems that astro page load event still needs to be subscribed to outside the if statement.

Anyway, I updated your fix in 68e8e6ab9a2a0cd440d0a15de20f12b0e92877c9. It is now released in 1.5.0.