Huskydog9988
commented
4 years ago The concepts behind this pr are wonderful, tho some changes to code should be made as I’ve already noticed multiple flaws in testing and from reading the code. One: the guest page has an improper irl for the css. (I think even more of the pages have this issue as well.) Two: the 500 and 404 error handlers are conflicting with each other and need to be hoisted higher in the code. Three: the authentication checker only allows the user if authenticated to access the "dashboard" page. Four: I don’t understand the need for a change between the login page to the guest page. I’ve seen no difference other then a different url and file. I would like to reiterate that I do agree that the error handling, and readme changes, are all wonderful but some thing do need to be changed in my opinion.
Please describe the changes you made: 404.ejs Error Catching Page. HTML/CSS Configured (Completed) 500.ejs Error Catching Page. HTML/CSS Configured (Completed) Thought about chaning .ejs error pages to using pug, but decided to stick with the theme of .ejs files.
User login check now sends to Guest/Info page if not authenticated. (Working on Caching authentication for faster returns to user control panel)
Added the Guest.ejs page and created a Basic text input of general information words.
Reworded text in Readme.
Added and adjusted commenting to .env, and a few current ones that already existed.
Attempted to combine test.js and index.js into one, "Fell asleep on the keyboard and replaced it back with what was already there (AKA No change).
Ran "Beautify" through all codebase files before sending out. I hope it looks somewhat nicer for everyone. If you don't like me running beauty then let me know I guess.
Sorry if I missed anything.
Type of change: Select one or multiple if needed.