shivagunasehkaran
commented
2 years ago Hi Daniel,
Thanks for the response and detailed review of my code.
I really appreciate it for kudos.
Regarding the improvements :
-
Use more arrow functions :
- Of course, I could have used ES5 syntax for the modern code. I agree and I will improve in the future. ( I will take it as a resolving comment )
-
Why not use an Expo project? Overcomplicated it a bit :
- The company i worked so far, never had expo and i did not get the opportunity to work in Expo.
- Willing to learn in the future.
-
Unneeded use of let variable initialization :
- It's a mistake and i will correct it the future.
-
No testing added :
- I try covering all test cases but was getting some errors and you can see the basic test cases i covered for UI.
- due to workload in the current company i could not spend much time for the error fixing in the test cases.
- definitely i would improve the test cases in future if i get some time.
Hi Sivakumar,
I’m Daniel, Associate Dir of Eng in HelloFresh Canada. I just finished reviewing your test! At HelloFresh, we encourage code reviews to give our applicants constructive feedback and discuss it interactively.
First of all, I want to thank you for the efforts you put into the test. To summarise my overview:
Kudos for:
Points you could improve:
I hope you have enjoyed working on this test and taking the review. This is a little demonstration of how we work at HelloFresh. I'm looking forward to hearing your thoughts on the points I mentioned in this review.
Please go through the couple of comments I left on this pull request, and feel free to add any replies or ask any questions, however, please don't submit any further commits as we won't be able to review them.