Booking improvements - Githubissues

shivamguys / irctc-cypress-automation

Tatkal and Normal train Booking Automation in 1 Minute ✔️ Signing in with your username and password. ✔️ Auto Upgradation Enabled. ✔️ Filling Captchas and retrying untill success. ✔️ Support for Food Choices, Seats Preferences. ✔️ Payment Gateway Automation (Paying With UPI ID OR QR Code).

92 stars 142 forks source link

Booking improvements #8

Closed drtechie closed 9 months ago

drtechie commented 10 months ago

Added Boarding station option

Some trains show tickets "NOT AVAILABLE" when booking tatkal between intermediate stations. In such trains, one has to book a tatkal from the starting station and change the boarding station to the intermediate station.
Added support for BOARDING_STATION, this attribute can be left null if not required. Otherwise, the name of the station can be used.

Ensure the click is 10 AM / 11 AM when booking opens.

Earlier the script clicked the availability every 1.9 seconds. Since the server is too slow around 10 AM, valuable time is lost.
This change ensures that the click is made at exactly 10 AM!

Option for manual CAPTCHA entry

Google text detection is unreliable. If it's wrong, valuable time is lost. It takes way too long for the next CAPTCHA to load.
Manual captcha option if kept true will require manual intervention from the user.

Bug fix

Missed index variable in food choice, added the same.

shivamguys commented 10 months ago

Will merge this after checking any test cases for the sample stations? @drtechie

drtechie commented 9 months ago

@shivamguys made more improvements, edited the PR description too.

shivamguys commented 9 months ago

Will look into it, busy schedules these days

On Sun, 19 Nov, 2023, 11:16 pm Mithun James, @.***> wrote:

@shivamguys https://github.com/shivamguys made more improvements, edited the PR description too.

— Reply to this email directly, view it on GitHub https://github.com/shivamguys/irctc-cypress-automation/pull/8#issuecomment-1817928630, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGAX65K2HP4H2UIVZL4CZMTYFJAWPAVCNFSM6AAAAAA7HEKRR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJXHEZDQNRTGA . You are receiving this because you were mentioned.Message ID: @.***>

shivamguys commented 9 months ago

performing a live run with this.....i dont know but taking risk

suspect something will mess with this line cy.get('div.h_head1', {timeout: 300000}).should('include.text', exactTimeToOpen)

shivamguys commented 9 months ago

@drtechie this manual captcha interaction is awesome thanks a ton for improving this....

drtechie commented 9 months ago

@shivamguys login around 9.57 or so and wait for the click to happen at exactly 10 AM. Irctc servers and login sessions are so unreliable. Good luck. 🤞🏾

shivamguys commented 9 months ago

thanks buddy @drtechie

drtechie commented 9 months ago

cy.get('div.h_head1', {timeout: 300000}).should('include.text', exactTimeToOpen)

That line is to wait for the clock to turn 10 AM. Hope it works. 😄

shivamguys commented 9 months ago

yup

shivamguys commented 9 months ago

trying now running the script @drtechie

shivamguys commented 9 months ago

@drtechie suspected worked

shivamguys commented 9 months ago

theres a problem

drtechie commented 9 months ago

How did you reach this page? The wait was on the train search list page. 🤔

shivamguys commented 9 months ago

yup it clicked exactly at 10 but the call was still waiting for this cy.get('div.h_head1', {timeout: 300000}).should('include.text', exactTimeToOpen)

this wont proceed ahead right because even one second after 10:00:01 would give the execution back to that function as we are performing a recursion over there right .... and after a second execution would still be waiting to match the exact time 10:00:00

and it was waiting and that passenger page opened and i had to fill the details manually then.

However at last i faced server issue of irctc and i had to then book manually for 2AC at 10:09 luckily i got it.....