search

shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.
https://setup-php.com
MIT License
2.92k stars 341 forks source link

Fail if `setup-php` was unable to install the requested PHP version #709

Closed weirdan closed 1 year ago

weirdan commented 1 year ago

Describe the feature

setup-php should fail when it's unable to install the requested PHP version

Version

Underlying issue

Currently, when setup-php fails to set up the requested PHP version, the build continues with the PHP version provided by the runner environment, which may not be compatible with the software being built/tested.

Describe alternatives

I tried to use env: fail-fast: true to no avail.

Additional context

image

This happens intermittently but quite often, so I couldn't run it with debugging enabled.

https://github.com/vimeo/psalm/actions/runs/4401974668/jobs/7708673538

Are you willing to submit a PR?

I'm not sure I'll be able to do this.

shivammathur commented 1 year ago

Fixed in https://github.com/shivammathur/setup-php/commit/5f422817a1c142632541535cd6e75a173d61d12f.

Will be in the next release.

shivammathur commented 1 year ago

Fix released in 2.25.0.