shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.
https://setup-php.com
MIT License
2.9k stars 337 forks source link

Installing `scoutapm` extension no longer works #738

Closed asgrim closed 1 year ago

asgrim commented 1 year ago

Describe the bug There appears to be some kind of regression installing the scoutapm PHP extension. Not sure why at the moment. Previously specifying extensions: scoutapm would install the scoutapm extension. Example build from 2nd May here.

Now, if I try the same job, I get the following error:

==> Setup Extensions
PHP Warning:  PHP Startup: Invalid library (appears to be a Zend Extension, try loading using zend_extension=/usr/lib/php/20170718/scoutapm.so from php.ini) in Unknown on line 0
✗ scoutapm Could not install scoutapm on PHP 7.2.34
Error: The process '/usr/bin/bash' failed with exit code 1

Example build from today here.

This is correct, scoutapm is a Zend Extension, but previously whatever the shivammathur/setup-php action did to install it was working...

Version

Runners

Operating systems

Ubuntu, Windows

PHP versions PHP 7.2 through to 8.2

To Reproduce

https://github.com/scoutapp/scout-apm-php/blob/a67f695640d073f6c7322e1b24f3e8af3881e729/.github/workflows/continuous-integration.yml#L391-L397

Expected behavior

I expect scoutapm to be successfully installed still.

Screenshots/Logs

Additional context

Are you willing to submit a PR?

shivammathur commented 1 year ago

Sorry for the regression.

This is fixed in https://github.com/shivammathur/setup-php/commit/fb5054b163daf85f4e3cd73641c0a4b51ad32b6f. It will be in the next release.

shivammathur commented 1 year ago

Released 2.25.3 with the fix. https://github.com/shivammathur/setup-php/releases/tag/2.25.3

asgrim commented 1 year ago

Thank you!