shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.
https://setup-php.com
MIT License
2.91k stars 340 forks source link

Debug symbols not included in libphp 8.3 ZTS even when debug set to true #784

Closed dunglas closed 11 months ago

dunglas commented 11 months ago

Describe the bug libphp8.3.so ZTS is stripped even when debug is true.

Version

Runners

Operating systems Ubuntu 22.04.3 LTS

PHP versions PHP 8.3 nightly

To Reproduce

     -
        uses: shivammathur/setup-php@v2
        with:
          php-version: 8.3
          ini-file: development
          coverage: none
          tools: none
        env:
          phpts: ts
          debug: true

Expected behavior Debug symbols should be included.

Screenshots/Logs

$ file /usr/lib/libphp8.3.so
/usr/lib/libphp8.3.so: ELF 64-bit LSB shared object, x86-64, version 1 (GNU/Linux), dynamically linked, BuildID[sha1]=0aaebe820406e66a76acb2588689bc16bbd023dc, stripped

Additional context n/a

Are you willing to submit a PR? yes

shivammathur commented 11 months ago

@dunglas

Fixed in https://github.com/shivammathur/php-builder/commit/66b1f71fa436eb11d1e490453e317e04fa360cdb

The file command would still say stripped at the end, but the debug files should be there in the correct directory in /usr/lib/debug/ and the debugger should pick debuginfo from them.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/6902553939/workflow

dunglas commented 11 months ago

Thank you!