Closed davereid closed 9 months ago
@davereid
Please update this regex here for lowest
and change the target to the develop branch.
https://github.com/shivammathur/setup-php/blob/main/src/utils.ts#L62
@davereid
Please run build and release, and add the changes.
npm run build
npm run release
Added the files after the npm run build/release. I did run npm test but there are current failures on the main branch on my local and my branch did not change or add any failures.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
dddb642
) 100.00% compared to head (93745da
) 100.00%. Report is 4 commits behind head on develop.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@davereid
Thanks for contributing π
It should be in the next release.
Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/7132635676/workflow
name: π New Feature about: Add option for a
lowest
supportedphp-version
parameter labels: enhancementA Pull Request should be associated with a Discussion.
Related discussion: https://github.com/shivammathur/setup-php/issues/793
Description
This PR [briefly explain what it does]
npm run format
before the commit.npm run lint
before the commit.npm run release
before the commit.npm test
returns with no unit test errors and all code covered.