Provide a "lowest" php-version parameter

davereid commented 9 months ago

name: 🎉 New Feature about: Add option for a lowest supported php-version parameter labels: enhancement

A Pull Request should be associated with a Discussion.

If you're fixing a bug, adding a new feature or improving something please provide the details in discussions, so that the development can be pointed in the intended direction.

Further notes in Contribution Guidelines Thank you for your contribution.

Description

This PR [briefly explain what it does]

In case this PR introduced TypeScript/JavaScript code changes:

[ ] I have written test cases for the changes in this pull request
[x] I have run npm run format before the commit.
[x] I have run npm run lint before the commit.
[x] I have run npm run release before the commit.
[ ] npm test returns with no unit test errors and all code covered.

In case this PR edits any scripts:

[ ] I have checked the edited scripts for syntax.
[ ] I have tested the changes in an integration test (If yes, provide workflow YAML and link).

shivammathur commented 9 months ago

@davereid

Please update this regex here for lowest and change the target to the develop branch. https://github.com/shivammathur/setup-php/blob/main/src/utils.ts#L62

shivammathur commented 9 months ago

@davereid

Please run build and release, and add the changes.

npm run build
npm run release

davereid commented 9 months ago

Added the files after the npm run build/release. I did run npm test but there are current failures on the main branch on my local and my branch did not change or add any failures.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dddb642) 100.00% compared to head (93745da) 100.00%. Report is 4 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #794 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 7 7 Lines 591 591 Branches 99 99 ========================================= Hits 591 591 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shivammathur commented 9 months ago

@davereid

Thanks for contributing 🎉

It should be in the next release.

Test workflow: https://github.com/shivammathur/test-setup-php/actions/runs/7132635676/workflow

shivammathur / setup-php