search

shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.
https://setup-php.com
MIT License
2.91k stars 339 forks source link

Configure `COMPOSER_PROCESS_TIMEOUT` #811

Closed Bilge closed 7 months ago

Bilge commented 8 months ago

Describe the feature Configure COMPOSER_PROCESS_TIMEOUT.

Version

Underlying issue I just had two composer test jobs fail on GitHub Actions after a 6 hours timeout (the maximum allowed), burning through 720 minutes of allowance for no reason, all because this action quietly disables the timeout feature entirely. This is not safe or a good idea; the timeout is enabled by default for good reason. Regardless of whether you agree, this should be configurable.

Describe alternatives I could probably manually override the timeout in each step or command where I require the timeout, though doing so would be laborious and hacky.

Are you willing to submit a PR? No, I don't know TypeScript or how to test actions in development.

shivammathur commented 8 months ago

I would not change it as that would be a breaking change, but support for COMPOSER_PROCESS_TIMEOUT env can be added.

Bilge commented 8 months ago

Yes, that is what I was driving at.

shivammathur commented 7 months ago

Added support in https://github.com/shivammathur/setup-php/commit/a6ce3f5633527c57a57c95fea21a2f686f7d9acb. Will be in next release.

shivammathur commented 7 months ago

Released in 2.30.0.