search

shivammathur / setup-php

GitHub action to set up PHP with extensions, php.ini configuration, coverage drivers, and various tools.
https://setup-php.com
MIT License
2.85k stars 334 forks source link

Apple ARM GitHub runners fail on PHP #825

Closed Lewiscowles1986 closed 5 months ago

Lewiscowles1986 commented 5 months ago

Describe the bug

https://github.com/pact-foundation/pact-php/pull/497

(in fact lots of recent runs) which use this, error when trying to setup php

Version

Runners

Operating systems

MacOS, ARM

PHP versions

8.1, 8.2, 8.3

To Reproduce

name: Code Analysis & Test

on:
  push: 
test:
    runs-on: macos-14
    steps:
      - uses: actions/checkout@v4
        name: Checkout repository

      - name: Setup PHP
        uses: shivammathur/setup-php@v2
        with:
          extensions: sockets, curl, zip, ffi
          php-version: 8.2
          coverage: none
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expected behavior

No warnings about dylib

Screenshots/Logs

https://github.com/pact-foundation/pact-php/actions/runs/8074546373/job/22060026690?pr=494

Additional context

As your job passes, I never thought about it twice, but looking at the logs, it seems to be the root cause.

Are you willing to submit a PR?

If it stays open long enough. Watching failing builds is making my eye twitch

From https://github.com/pact-foundation/pact-php/pull/497

shivammathur commented 5 months ago

Fixed in 2.30.0.

Please try running the workflow again.

Lewiscowles1986 commented 4 months ago

Fixed, thanks https://github.com/pact-foundation/pact-php/actions/runs/8106412833/job/22156308207?pr=501

Lewiscowles1986 commented 4 months ago

I'm so curious looking at that non-build script change in how it fixed this 😂 . Found it

https://github.com/shivammathur/setup-php/commit/4f6ab99328e4991dc5933e4f32c533545d4ee527 this is the actual commit I think. So homebrew must have been a bit messed up, simplifying fixed.