Closed Sn0wCrack closed 1 month ago
shivammathur
commented
2 months ago @Sn0wCrack
Please provide the workflow you are using.
Also please ensure that you are specifying runner env as self-hosted.
https://github.com/shivammathur/setup-php?tab=readme-ov-file#self-hosted-setup
Sn0wCrack
commented
2 months ago It looks like I had some workflows that didn't have the self-hosted env, which is probably why this occurred.
I'll make this change and see if this resolves the issue by itself.
shivammathur
commented
2 months ago @Sn0wCrack Following up on this, were you able to fix it on your end.
Sn0wCrack
commented
2 months ago Sorry for not updating, had not had a change to test the changes after implementing them, took some time to go through all of our repositories as well, only a handful of workflows were missing the environment variable.
I've tested it again now after adding the runner environment variable and I still receive these warnings on those servers.
I'm assuming this fix won't be retroactive and I might have to manually remove the installed PHP 8.3 to have the action pull down the correct files again?
Here's my action workflow file for reference as well:
name: Continuous Integration
# Controls when the workflow will run
on:
workflow_dispatch:
push:
branches: [ master ]
paths:
- '**.php'
- '**.js'
- '**.vue'
- '**.ts'
- '**.json'
- '**.lock'
tags-ignore:
- 'v*'
pull_request:
branches: [ master ]
paths:
- '**.php'
- '**.js'
- '**.vue'
- '**.ts'
- '**.json'
- '**.lock'
jobs:
lint:
runs-on: [ self-hosted, Linux, ci ]
strategy:
matrix:
php-version: ['8.3']
steps:
- uses: actions/checkout@v4
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
extensions: bcmath, ctype, fileinfo, json, mbstring, openssl, pdo, pdo_mysql tokenizer
tools: composer
env:
runner: self-hosted
- name: Setup Node
uses: actions/setup-node@v3
with:
cache: 'yarn'
node-version: 'lts/iron'
- name: Install JavaScript Dependencies
run: yarn install --frozen-lockfile
- name: Install PHP Dependencies
uses: ramsey/composer-install@v3
- name: Lint JavaScript
run: yarn lint
- name: Lint PHP
run: ./vendor/bin/pint --test
test:
runs-on: [ self-hosted, Linux, ci ]
services:
database:
image: mariadb:10
env:
MYSQL_DATABASE: database
MYSQL_ALLOW_EMPTY_PASSWORD: false
MYSQL_ROOT_PASSWORD: password
ports:
- 3306
options: >-
--health-cmd="mysqladmin ping"
--health-interval=10s
--health-timeout=5s
--health-retries=3
cache:
image: redis:7
ports:
- 6379
strategy:
matrix:
php-version: ['8.3']
steps:
- uses: actions/checkout@v4
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php-version }}
extensions: bcmath, ctype, fileinfo, json, mbstring, openssl, pdo, pdo_mysql tokenizer, redis, igbinary, gd, imagick
tools: composer
coverage: pcov
env:
runner: self-hosted
- name: Setup Node
uses: actions/setup-node@v3
with:
cache: 'yarn'
node-version: 'lts/iron'
- name: Install JavaScript Dependencies
run: yarn install --frozen-lockfile
- name: Install PHP Dependencies
uses: ramsey/composer-install@v3
- name: Build JavaScript
run: yarn dev
- name: Setup tasks
run: |
touch .env
php artisan storage:link
- name: Run Tests
run: php artisan test --coverage --parallel
Yes, it will require manually removing the previously installed version.
Describe the bug
Currently some of my self-hosted runners that have PHP 8.3 installed seem to output several warnigns about installed extensions failing to load in due to additionally missing linked libraries.
Some runners also seem to have slightly different PHP versions installed, with some having 8.3.0 and others having 8.3.6.
Version
v1orv2.v2v1Runners
Operating systems
Ubuntu 22.04.4 LTS
PHP versions
PHP 8.3
To Reproduce
Using PHP 8.3 on a self-hosted runner, unsure how this triggered in the first place for these runners.
Expected behavior
All required packages would be installed for these extensions
Screenshots/Logs
Output from running a PHP process on a server producing the error:
The above output pretty much appears any time any PHP action occurs, from composer install, to starting our test runs.
Additional context
This only seems to affect two of my self-hosted runners for whatever reason and not the others, I'm imagining this is just an issue that occurred when these were installed.
I am also aware for PHP 8.3 it was switched to use a custom build of PHP rather than using ondrej's PHP builds, so that would be why it only affects PHP 8.3 in this case.
All runners would have started using PHP 8.3 around the same time as well, as only a single project began using it and it would have triggered on all of them probably within a week or so of that occurring.
These servers should have the same base set of packages installed as well, as we provisioned them all from a basic Ubuntu 22.04 LTS server image and use a bash script to install all the packages and setup the GitHub Runner service.
Are you willing to submit a PR?
If it's something I can fix then I would happy to take a further look.