shivamsouravjha / stock-frontend

https://www.stocksight.online/

9 stars 19 forks source link

Updated the website title to StockSight and changed the logo to stag … #21

Closed prajesh9921 closed 1 month ago

prajesh9921 commented 1 month ago

Issue 11

Title: updating the title of the website which is Vite + React.

Work Done:

I have changed the title from "vite+react" to "StockSight"
I have added the favicon using the png available In public.
I have added a manifest.json file to the public to add icons according to different screen sizes.
removed the "vite. svg" code line from index.html.

Note

Please let me know if anything else is needed as I am a new contributor. Thank you

vercel[bot] commented 1 month ago

@prajesh9921 is attempting to deploy a commit to the shivamsouravjha's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stock-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 9, 2024 6:51pm

shivamsouravjha commented 1 month ago

why the package-lock.json file?

prajesh9921 commented 1 month ago

I did npm i it added that file automatically. npm basically adds that file for version consistency. I can delete if you want

shivamsouravjha commented 1 month ago

Its not needed please remove it

prajesh9921 commented 1 month ago

Removed the file.

shivamsouravjha commented 1 month ago

please also remove the yarn.lock file changes if you didn't install any new thing

prajesh9921 commented 1 month ago

I removed the yarn.lock file. Also can you please add the label "hacktoberfest" for this issue will help a lot.

shivamsouravjha commented 1 month ago

Hey @prajesh9921 I think theres some miscommunication I meant that remove the yarn lock changes not the entire file itself. Have added the label

prajesh9921 commented 1 month ago

oh ok ok Mybad I'll revert the changes

prajesh9921 commented 1 month ago

Restored the file. I have not made any changes yarn.lock maybe formatting of code might have changed due to my code formatter. Please let me know if you need anything else.