Closed shivamsouravjha closed 1 month ago
Hi @shivamsouravjha please assign it to me
@shivamsouravjha
Are we showing the rating and f9? @ayushmanyd ?
also instead of new column for link lets use the link in the name itself
@Ankesh2004 this would be pn first come first serve basis feel free to raise a pr
The API response has so many thing, should I display all?
Link in new column: Initially I thought the same but in Results page, Links are displayed like this so I changed my mind & applied the same.
@shivamsouravjha
Nope link should be in the name , we can show just main fields like stock name, Category , rating and stock rate Rest everything can be otpional (like a checkbox in top)
But category & rating is not in API response
Updated:
hey @ayushmanyd i think it is there
also stock rate is a rating we give not the price///and category is the market cap you gave..have more fields in general for future, for example if I add a field from backend it should automatically be present in check box without having to manually update in ui
Got it.
How about now?
Looks greay
Should I raise the PR?
Yes
https://stock-backend-hz83.onrender.com/api/fetchStocks
in each set we just get 10 stocks just we've pagination as well curl -X GEThttps://stock-backend-hz83.onrender.com/api/fetchStocks?pageNumber=2