shivamsouravjha / stock-frontend

https://www.stocksight.online/
9 stars 19 forks source link

feat: a page to list down all the stocks #65

Closed shivamsouravjha closed 1 month ago

shivamsouravjha commented 1 month ago
Ankesh2004 commented 1 month ago

Hi @shivamsouravjha please assign it to me

ayushmanyd commented 1 month ago

How about this? Let me know if something has to be changed.

image

@shivamsouravjha

shivamsouravjha commented 1 month ago

Are we showing the rating and f9? @ayushmanyd ?

also instead of new column for link lets use the link in the name itself

@Ankesh2004 this would be pn first come first serve basis feel free to raise a pr

ayushmanyd commented 1 month ago

The API response has so many thing, should I display all?

Link in new column: Initially I thought the same but in Results page, Links are displayed like this so I changed my mind & applied the same.

@shivamsouravjha

shivamsouravjha commented 1 month ago

Nope link should be in the name , we can show just main fields like stock name, Category , rating and stock rate Rest everything can be otpional (like a checkbox in top)

ayushmanyd commented 1 month ago

But category & rating is not in API response

Updated: image

shivamsouravjha commented 1 month ago

hey @ayushmanyd i think it is there

image

also stock rate is a rating we give not the price///and category is the market cap you gave..have more fields in general for future, for example if I add a field from backend it should automatically be present in check box without having to manually update in ui

ayushmanyd commented 1 month ago

Got it.

ayushmanyd commented 1 month ago

How about now?

image

shivamsouravjha commented 1 month ago

Looks greay

ayushmanyd commented 1 month ago

Should I raise the PR?

shivamsouravjha commented 1 month ago

Yes