shivamsouravjha / stock-frontend

https://www.stocksight.online/
9 stars 19 forks source link

Complete rebuild of UI layer #8

Closed devjayprakash closed 1 month ago

devjayprakash commented 1 month ago

I've rebuild the UI and added the following features

What's lacking (i'll add these eventually)

Screenshot Screenshot 2024-10-06 at 12 23 32 PM Screenshot 2024-10-06 at 12 23 21 PM

vercel[bot] commented 1 month ago

Someone is attempting to deploy a commit to the shivamsouravjha's projects Team on Vercel.

A member of the Team first needs to authorize it.

shivamsouravjha commented 1 month ago

we're using the google signup thing to access the portfolio directly from mail.

shivamsouravjha commented 1 month ago

isntead of stocksprint we can use stockSight because our aim is for more indepth insights of a stock

devjayprakash commented 1 month ago

we're using the google signup thing to access the portfolio directly from mail.

oh got it.. That makes sense

shivamsouravjha commented 1 month ago

there are few conflicts please resolved that rest everything is good to go

shivamsouravjha commented 1 month ago

can we put this as the logo https://github.com/shivamsouravjha/Stooler/blob/main/frontend/public/logo512.png ? (the one in top of window as well as the official logo)

devjayprakash commented 1 month ago

Sure i'll fix it .. Also we'll have to force push to to main as it's a complete rewrite. I'll add the google analytics as soon in a separate PR

shivamsouravjha commented 1 month ago

Won’t be force pushing we can just shift those things as others contribution might be lost as well.

Lets try to put everything in this pr including the analytics.

devjayprakash commented 1 month ago

Won’t be force pushing we can just shift those things as others contribution might be lost as well.

Lets try to put everything in this pr including the analytics.

Oh yes you are right.. sure i'll try to add other contributions to this one..

shivamsouravjha commented 1 month ago

let's try to wrap it up as there are few contributors who want to pick different task and it will be a mess for your if their prs are merged first and for them if yours merged after their changed. rest ui looks great!

shivamsouravjha commented 1 month ago

can't merge because of the conflicts and since this is a fork I can't fix them either

devjayprakash commented 1 month ago

can't merge because of the conflicts and since this is a fork I can't fix them either

As this is a complete re implementation it would not be possible to merge. You will have to pull this branch. Then push it by force to main . Here is how you can do it.

  1. Clone my repo somewhere (https://github.com/devjayprakash/stock-frontend)
  2. Add your repo as another remote git remote add shivam_origin this_repo_link
  3. Then you can push it to this repo by doing git push -u -f shivam_origin feature/rebuild_ui:main

Also i've re-implemented all the new commits. I'll working on the google thing now.

shivamsouravjha commented 1 month ago

have merged the same !

shivamsouravjha commented 1 month ago