shivanikhosa / browserscope

Automatically exported from code.google.com/p/browserscope
Apache License 2.0
0 stars 0 forks source link

Do not test non-numeric inputs to fontSize #326

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
There are a bunch of richtext2 tests that test non-numeric inputs, such as:

RTE2-AC_FS:18px_TEXT-1_SI: 18px
RTE2-AC_FS:large_TEXT-1_SI: large
RTE2-C_FS:larger_FONTsz:4: larger
RTE2-C_FS:smaller_FONTsz:4: smaller

and others.  Originally the editing spec required support for such values, but 
after consideration, I removed it:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=14251

Now the spec requires that browsers support only floating-point numbers for 
fontSize:

http://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#the-fontsize-command

Adding a new command that deals in CSS sizes instead of legacy sizes might well 
be a good idea, but browsers don't do that for fontSize, and it seems 
inadvisable to require/allow it.  Instead, we should add a new command:

https://www.w3.org/Bugs/Public/show_bug.cgi?id=14253

The major advantage of a new command is that queryCommandValue() will be able 
to return CSS sizes.  queryCommandValue("fontSize") currently returns only 
numbers 1-7, so it's really not suitable for use with anything but legacy 
numeric font sizes.  (FWIW, even in the new command I don't think we should 
support anything but absolute units, for reasons explained in 
<https://www.w3.org/Bugs/Public/show_bug.cgi?id=14251#c2>.)

So please remove any richtext2 tests for fontSize that use values other than 
floating-point numbers, to match the spec.  Thanks!

Original issue reported on code.google.com by Simetrical on 6 Apr 2012 at 9:36