search

shivanikhosa / browserscope

Automatically exported from code.google.com/p/browserscope
Apache License 2.0
0 stars 0 forks source link

UA Parsing Is Incorrect #337

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
We thought you were using the browser:
Safari 6

You are really using the browser:
WebKit Nightly

User-agent string is "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) 
AppleWebKit/537.8+ (KHTML, like Gecko) Version/6.0 Safari/536.25"

The notable difference between WebKit Nightly (on Mac) and Safari 6 is the "+" 
in "AppleWebKit/537.8+" part (it looks like Safari never has a "+" in the 
User-agent string):

*Safari:* Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/536.25 
(KHTML, like Gecko) Version/6.0 Safari/536.25
*WebKit:* Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.8+ 
(KHTML, like Gecko) Version/6.0 Safari/536.25

Original issue reported on code.google.com by mihai.ba...@gmail.com on 3 Sep 2012 at 8:09

GoogleCodeExporter commented 8 years ago 
It looks like the UA for WebKit nightly changed slightly (probably with the 
release of Safari 6):

OLD WebKit: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.1+ 
(KHTML, like Gecko) Version/6.0 Safari/536.25
NEW WebKit: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_7_4) AppleWebKit/537.8+ 
(KHTML, like Gecko) Version/6.0 Safari/536.25

notice the change from 537.1+ to 537.8+

Original comment by mihai.ba...@gmail.com on 3 Sep 2012 at 1:27

GoogleCodeExporter commented 8 years ago 
Thanks Mihai! I'm making the change here and on github =)

Original comment by els...@gmail.com on 3 Sep 2012 at 6:38

GoogleCodeExporter commented 8 years ago 
You're Awesome! Thanks a lot for these quick fixes!

Is the gitHub repo public? I can't seem to find it.

Original comment by mihai.ba...@gmail.com on 4 Sep 2012 at 5:13

GoogleCodeExporter commented 8 years ago 
Ummm.. you sure this got fixed? Neither r914 nor r915 seem to touch anything 
related to this.

Thanks in advance!

Original comment by mihai.ba...@gmail.com on 4 Sep 2012 at 5:45

GoogleCodeExporter commented 8 years ago 
The UA parser changes are here: 
http://code.google.com/p/ua-parser/source/detail?r=37 and 
https://github.com/tobie/ua-parser/commit/ac4909d2810966c167c2cd8f7135347e882268
95

Original comment by els...@gmail.com on 5 Sep 2012 at 4:27