Issue 109: Enable closing modals using the ESC key

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app

21 stars 43 forks source link

Closed MRodriguez-M closed 2 weeks ago

MRodriguez-M commented 3 weeks ago

Added handlers to the two modals in the app so that they close when the ESC key is pressed.

Addresses issue #109

[X] I have tested these changes locally.
[X] I have reviewed the code and ensured it follows the project's coding guidelines.
[ ] I have updated the documentation, if necessary.
[ ] I have assigned reviewers to this pull request.

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
multiplayer-uno	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 14, 2024 9:21pm

vercel[bot] commented 3 weeks ago

@MRodriguez-M is attempting to deploy a commit to the Shivansh Bhatanagar's projects Team on Vercel.

A member of the Team first needs to authorize it.

MRodriguez-M commented 2 weeks ago

Hi, I made the requested changes, just waiting for approval on this PR

kuv2707 commented 2 weeks ago

The commits don't seem to follow the project guidelines. There should have been one commit with a properly formatted explanatory message.

Anyway, the modal system revamp, tracked in #116 encompasses this issue, so it doesn't make much sense to work on it separately.

Thanks for all the work @MRodriguez-M