shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
19 stars 42 forks source link

client:Improve the structure of the modal #119

Closed ritwik-69 closed 3 months ago

ritwik-69 commented 3 months ago

fixes #116

Description

Created reusable modal which can be used in various part of the game.The is wrapped as it was causeing some problems in using navigation.The other modals were deleted and were remade using the component.Also ESlint is giving a warning which i am unable to solve.

Checklist

Note

I think we should update the documentation on how to use all the components created till now so that it will be easier to work in the future.

vercel[bot] commented 3 months ago

@ritwik-69 is attempting to deploy a commit to the Shivansh Bhatanagar's projects Team on Vercel.

A member of the Team first needs to authorize it.

ritwik-69 commented 3 months ago

@kuv2707 done with the changes 👍

kuv2707 commented 3 months ago

Please fix the lint check. You can eslint-ignore that line

kuv2707 commented 3 months ago

Also reply to each feedback comment indicating how you addressed the it

ritwik-69 commented 3 months ago

@kuv2707 had to redo the commits as their were some merge issues

ritwik-69 commented 3 months ago

@kuv2707 Finally done with changes

kuv2707 commented 3 months ago

@ritwik-69 Thanks for this great piece of contribution!