shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

Fix flicker when trying to create a game without logging in #142

Closed kuv2707 closed 1 week ago

kuv2707 commented 1 week ago

Description

When clicking on 'Create Game" without logging in, the screen flickers and a toast is displayed. This is because the GameProvider on mounting checks the auth state and returns if not logged in.

We can fix this flicker by checking it in the homepage itself, before navigating to the game page. (We should leave the GameContext undisturbed)

issue-assigner[bot] commented 1 week ago

Comment '@csoc-bot claim' to get this issue assigned or '@csoc-bot abandon' to get this issue unassigned.

kuv2707 commented 1 week ago

This issue is suitable for first timers

sethdivyansh commented 1 week ago

@kuv2707 Also JoinGameModal appears on clicking start game without logging in.

https://github.com/shivansh-bhatnagar18/multiplayer-uno/assets/59174836/2f9eec8b-88ae-4e36-82ae-d4cbc772e5ee

kuv2707 commented 1 week ago

Yes, i know. That modal has its own problems, to be handled separately

Spikoftw commented 1 week ago

@csoc-bot claim

issue-assigner[bot] commented 1 week ago

@Spikoftw This issue has been successfully assigned to you! 🚀