shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

Frontend: Added password rules in sign up page #143

Closed Lavina-11 closed 1 week ago

Lavina-11 commented 1 week ago

Description

Related Issues

Fixes: #133

Checklist

Screenshots

Screenshot 2024-06-21 214813

vercel[bot] commented 1 week ago

@Lavina-11 is attempting to deploy a commit to the Shivansh Bhatanagar's projects Team on Vercel.

A member of the Team first needs to authorize it.

kuv2707 commented 1 week ago

Seems good enough, please fix the failing frontend checks. You can use npm run fix-format to fix prettier errors, and manually address the eslint errors (though they seem to coincide with the prettier errors)

Lavina-11 commented 1 week ago

Seems good enough, please fix the failing frontend checks. You can use npm run fix-format to fix prettier errors, and manually address the eslint errors (though they seem to coincide with the prettier errors)

Hi, Thanks for the suggestions. Have updated the code accordingly. Please review the code whenever you get a chance.

kuv2707 commented 1 week ago

Your commit history shows a merge commit. Also, you shouldn't have commits introducing errors and subsequent commits fixing them - rather the original commit must be modified to fix the error.

In your case, it is sufficient to squash the 3 commits into one. You can run git rebase -i HEAD~3 to select the last 3 commits. A window will appear, where you replace pick with squash on two of the later commits. After saving and closing, you will be asked to enter the commit message of the new commit (containing the 3 squashed commits).

Enter a properly formatted message (same as the first commit on this PR). Do not mention that you corrected prettier errors, since no one would be able to know that there existed any error in the first place, so it would be a useless mention.

After entering the commit message and saving then closing, you will have to execute git push --force. This rewrites the 3 commits on the remote branch (which is reflected here in the PR) with the one commit you locally created.