shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

changed a to link #155

Closed draunger closed 1 week ago

draunger commented 1 week ago

Description

[Provide a brief description of the changes made in this pull request.]

Motivation and Context

[Explain the motivation behind these changes and provide any relevant context.]

How to Test

[Describe the steps to test the changes made in this pull request.]

Related Issues

[If applicable, mention any related issues or pull requests.]

Checklist

Screenshots (if applicable)

[If your changes include any visual updates, provide screenshots here.]

vercel[bot] commented 1 week ago

@draunger is attempting to deploy a commit to the Shivansh Bhatanagar's projects Team on Vercel.

A member of the Team first needs to authorize it.

kuv2707 commented 1 week ago

Please fix the failing test. Perhaps you forgot to import Link from react-router-dom

kuv2707 commented 1 week ago

Please fix the prettier check (running npm run fix-format) Also, The changes should be done in the same commit - so that it passes all the checks. You can refer to CONTRIBUTING.MD for how to edit commits. You can ask doubts in the discussions.

kuv2707 commented 1 week ago

Please restructure your commits so that all the changes are there in one commit. You can squash the commits.

kuv2707 commented 1 week ago

@draunger The commit message doesn't follow the guidelines. I am editing it myself, but please note that henceforth.

Also once you make changes and want a review, do tag a maintainer.

kuv2707 commented 1 week ago

Merged, thanks @draunger

draunger commented 1 week ago

@kuv2707 thanks