Frontend: Improve Styling Of Toast Component.

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app

21 stars 43 forks source link

Frontend: Improve Styling Of Toast Component. #163

Closed asmit27rai closed 1 week ago

asmit27rai commented 1 week ago

Description

Improve Styling Of Toast Component.

Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code and ensured it follows the project's coding guidelines.
[ ] I have updated the documentation, if necessary.
[ ] I have assigned reviewers to this pull request.

Screenshots (if applicable)

Warning
Error 3.Info 4.Success

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
multiplayer-uno	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 24, 2024 9:01pm

kuv2707 commented 1 week ago

Also, do fix the prettier check in the current commit and update the commit with it

asmit27rai commented 1 week ago

Looks phenomenal! Also appreciate the minor improvements in the current implementation. Could you make it so that the toast hast two components: a heading and then the actual content. We can modify the message variable from string to object, containing fields heading and content. We must refactor existing toasts with this change too.

This can be done in a separate commit, following the current changes.

But because of this change we have to change all files that contains give message through toast ?