engine: improved card drawing logic. - Githubissues

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app

20 stars 43 forks source link

engine: improved card drawing logic. #48

Closed sethdivyansh closed 1 month ago

sethdivyansh commented 1 month ago

Fixes: #8

Description

Handles the card drawing logic from an empty cardDeck.

Reshuffles the thrown cards into the card deck when the card deck is empty and a player needs to draw a card.
Return Succes or Error based on the outcome.
Also added relevant unit test, in engine.test.ts, to verify this drawCardFromDeck() works correctly.

How to Test

I have created a sample test in engine.test.ts. just run npm test

Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code and ensured it follows the project's coding guidelines.
[ ] I have updated the documentation, if necessary.
[ ] I have assigned reviewers to this pull request.

kuv2707 commented 1 month ago

Merged, thanks @sethdivyansh !