search

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
20 stars 43 forks source link

gameEvent: Implement Throw Card Event #50

Closed criticic closed 1 month ago

criticic commented 1 month ago

Description

adds the throw card handler

Fixes #44

Motivation and Context

[Explain the motivation behind these changes and provide any relevant context.]

How to Test

[Describe the steps to test the changes made in this pull request.]

Related Issues

[If applicable, mention any related issues or pull requests.]

Checklist

Screenshots (if applicable)

[If your changes include any visual updates, provide screenshots here.]

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 12, 2024 2:17pm
kuv2707 commented 1 month ago

@criticic Please prioritize this PR over any new work as this will help further work on the engine.

kuv2707 commented 1 month ago

@criticic Are you working on it or should I close it?

criticic commented 1 month ago

I’ll send a updated PR by tonight

On 11 Jun 2024, at 11:14 AM, Kislay @.***> wrote:

@criticichttps://github.com/criticic Are you working on it or should I close it?

— Reply to this email directly, view it on GitHubhttps://github.com/shivansh-bhatnagar18/multiplayer-uno/pull/50#issuecomment-2159840226, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJVJDCRQRLZ4Z66WSIF7XTLZG2FDTAVCNFSM6AAAAABIUZLLWKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJZHA2DAMRSGY. You are receiving this because you were mentioned.Message ID: @.***>

kuv2707 commented 1 month ago

Merged, thanks @criticic

criticic commented 1 month ago

Just pushed a commit, did that end up being merged?

On 13 Jun 2024, at 12:11 AM, Kislay @.***> wrote:

Merged #50https://github.com/shivansh-bhatnagar18/multiplayer-uno/pull/50 into master.

— Reply to this email directly, view it on GitHubhttps://github.com/shivansh-bhatnagar18/multiplayer-uno/pull/50#event-13135989875, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AJVJDCVMFYZI2IOG5E6WYTTZHCI4NAVCNFSM6AAAAABIUZLLWKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGEZTKOJYHE4DONI. You are receiving this because you were mentioned.Message ID: @.***>

criticic commented 1 month ago

hey @kuv2707 please see the latest branch: https://github.com/criticic/csoc-multiplayer-uno/tree/feat/event-throw-card