shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
20 stars 43 forks source link

frontend: added error page #58

Closed PrathamX595 closed 1 month ago

PrathamX595 commented 1 month ago

Added Error Page

Fixes: #21

Description

added an error page which is rendered when an unknown route is accessed, it contains a link to go back to home page of the game.

How to Test

  1. use the command npm run dev in the console and open the application.
  2. In the search box add /k (or any other route which is not recognized by the router) after the existing text.

Checklist

Screenshots (if applicable)

70e10a13-76c8-4561-8532-b4486e8272bd

PrathamX595 commented 1 month ago

@kuv2707 the previous PR(#35 ) was closed by mistake kindly review this PR and continue from here the requested changes have been implemented

kuv2707 commented 1 month ago

Seems good to me, but the design decisions will be made by others

shivansh-bhatnagar18 commented 1 month ago

Thank you @PrathamX595 for your Pull Request. Every Pull request matters but we have found out a better Error page for the same. For now I am closing this issue.