Server: Implement doSendEvents Fun

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app

20 stars 43 forks source link

Server: Implement doSendEvents Fun #63

Closed asmit27rai closed 1 month ago

asmit27rai commented 1 month ago

Complete doSendEvents Fun

Fixes #61

Description

Work On doSendEvent Function that send event if response object is available.

Checklist

[x] I have tested these changes locally.
[x] I have reviewed the code and ensured it follows the project's coding guidelines.
[ ] I have updated the documentation, if necessary.
[ ] I have assigned reviewers to this pull request.

kuv2707 commented 1 month ago

@asmit27rai Please resolve the merge conflicts and also amend the commit message. The fixes suggested in the review should not be a separate commit, neither should they be mentioned there.

The commit message should have a summary of the final changes that are there in the commit. Squash the commits and enter a proper commit message. This would be good to go then.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
multiplayer-uno	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2024 5:04pm

asmit27rai commented 1 month ago

@asmit27rai Please resolve the merge conflicts and also amend the commit message. The fixes suggested in the review should not be a separate commit, neither should they be mentioned there.

The commit message should have a summary of the final changes that are there in the commit. Squash the commits and enter a proper commit message. This would be good to go then.

Conflicts Resolved.

kuv2707 commented 1 month ago

@asmit27rai That has introduced a merge commit.

Also the PR affects some unrelated files

asmit27rai commented 1 month ago

@asmit27rai That has introduced a merge commit.

Also the PR affects some unrelated files

Done

kuv2707 commented 1 month ago

Please remove all other changes not related to the issue.

The PR is fit to be merged, once that is done

asmit27rai commented 1 month ago

Please remove all other changes not related to the issue.

The PR is fit to be merged, once that is done

Done.

kuv2707 commented 1 month ago

The commit message still isn't perfect, but I'm ignoring this time. Please respect the commit message format.

kuv2707 commented 1 month ago

Merged, thanks @asmit27rai and @sksmagr23