shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

Frontend: Added a customizable and reusable heading component #75

Closed sksmagr23 closed 1 month ago

sksmagr23 commented 1 month ago

Description

I have created a highly customizable and reusable header component in src/library, and the styling is done using tailwind css and added various input fields as props.

I have also modified and updated my previously created playoptions page(which is merged) with this heading component. This heading component has various props which you can see in attached screenshot.

Fixes: #67

How to Test

Related Issues

Checklist

Screenshots

Screenshot from 2024-06-07 11-23-06 Screenshot from 2024-06-07 12-44-11

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:13am
kuv2707 commented 1 month ago

Please update the PR description to contain the clause Fixes: #issueno since that is what's used by github to associate the issue with the PR

kuv2707 commented 1 month ago

Also, please add screenshots of dummy headings created using this component, demonstrating various configurations

sksmagr23 commented 1 month ago

updated the description and added screenshot of dummy headings

kuv2707 commented 1 month ago

Looks great!

kuv2707 commented 1 month ago

Please amend the fixes clause in the commit message just like the description. Also restrict around 72 characters per line in the message.

You'd just need to run git commit --amend and insert line breaks as appropriate. Save the changes and exit, then run git push --force

It can be merged once these changes are made.

sksmagr23 commented 1 month ago

@kuv2707 I have done the changes