shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

Client:Implemented the input component #80

Closed ritwik-69 closed 3 weeks ago

ritwik-69 commented 1 month ago

fixes:#77

Description

Created the Input component as discussed and made in figma. As props it takes normal input properties like placeholder,value etc. The styling has been done in input.css (I had to rename it input.css from input.module.css as it was not working when importing)

Motivation and Context

[Explain the motivation behind these changes and provide any relevant context.]

How to Test

[Describe the steps to test the changes made in this pull request.]

Related Issues

[If applicable, mention any related issues or pull requests.]

Checklist

Screenshots (if applicable)

[If your changes include any visual updates, provide screenshots here.]

image

input code

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 0:59am
shivansh-bhatnagar18 commented 1 month ago

@ritwik-69 Can you please use tailwind for styling of components as much as possible? Also I am configuring Kavoom to the tailwind file so change the fonts accordingly.

ritwik-69 commented 4 weeks ago

@shivansh-bhatnagar18 I used tailwing css and configured it to include kavoon font

kuv2707 commented 4 weeks ago

@ritwik-69 Please update the screenshots, and rebase your branch once (against upstream/master)

ritwik-69 commented 4 weeks ago

@kuv2707 done with the changes

shivansh-bhatnagar18 commented 4 weeks ago

@ritwik-69 Please fix the merge conflicts. The component looks good but add some basic parameters as width and height as parameters. Also remove the related input CSS files because you are already using tailwind

ritwik-69 commented 4 weeks ago

@shivansh-bhatnagar18 I don't understand why vercel deployment is failing?

shivansh-bhatnagar18 commented 4 weeks ago

@ritwik-69 You are still importing ./input.css in the input.tsx. To check why this deployment fails try running npm run build Screenshot from 2024-06-08 19-44-09

ritwik-69 commented 4 weeks ago

@ritwik-69 You are still importing ./input.css in the input.tsx. To check why this deployment fails try running npm run build Screenshot from 2024-06-08 19-44-09

sorry about that 🤦‍♂️

ritwik-69 commented 4 weeks ago

@shivansh-bhatnagar18 Done with the changes

shivansh-bhatnagar18 commented 3 weeks ago

@ritwik-69 Please change the font to kavoon