search

shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

issue #81 fixed #91

Closed AB000001 closed 3 weeks ago

AB000001 commented 3 weeks ago

Description

Fixes #81. Converted gameControllers.js to gameControllers.ts

Motivation and Context

Issue #81 fixed

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
multiplayer-uno ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 9:44am
kuv2707 commented 3 weeks ago

@AB000001 Still on it?

AB000001 commented 3 weeks ago

Great work! Please take a moment to read the contributing guidelines (in the file contributing.md) and format the PR description and commit message accordingly.

The PR description should have the clause Fixes #issueno.

Once that is done, this can be merged

Modified the Pull request description to include issue #81. and modified the commit remark also

kuv2707 commented 3 weeks ago

@AB000001 The commits don't seem to follow the guidelines. There should only be one commit with a properly formatted message. The contributing docs can help you with it. You need to "squash" all the commits into one.

Also I'd expect only one file change as per the issue description, but here there are two.

kuv2707 commented 3 weeks ago

It seems like this issue has been addressed in a recent commit, since the file is now in typescript. In that case, it would be useless to work further on it.

You can still use this PR to learn some git commands, and I'll approve it once it is in good shape, so that it is counted as a contribution. (Just be sure not to "rebase" this branch).

I'll unassign you from the issue so that you can take up others. Thanks for all the work!

kuv2707 commented 3 weeks ago

closing due to inactivity