shivansh-bhatnagar18 / multiplayer-uno

https://multiplayer-uno.vercel.app
21 stars 43 forks source link

Implement the Game page #95

Closed kuv2707 closed 3 weeks ago

kuv2707 commented 3 weeks ago

Description

This is the most complex part of the project.

Specs

The page should roughly have this appearance: Imagen de WhatsApp 2024-06-11 a las 23 04 54_6e19a05d

We primarily focus on functionality, and can later tweak the design as seems fit.

issue-assigner[bot] commented 3 weeks ago

Comment '@csoc-bot claim' to get this issue assigned or '@csoc-bot abandon' to get this issue unassigned.

sksmagr23 commented 3 weeks ago

@csoc-bot claim

issue-assigner[bot] commented 3 weeks ago

@sksmagr23 This issue has been successfully assigned to you! 🚀

sksmagr23 commented 3 weeks ago

@kuv2707 this page should render at which route?

kuv2707 commented 3 weeks ago

@sksmagr23 So here's an outline:

I think it would make sense to handle all using a GameContext. The actual Game component will then retrieve the players and their cards from the context and render the UI. The Game component will only be rendered once the initial game state is received from the server (whether hosting or joining a game).

This seems too huge, so it would require many further discussions on the implementation, and can encompass many plan changes.

sksmagr23 commented 3 weeks ago

Ok , I will start implementing things one by one, once the login/signup component is merged

kuv2707 commented 3 weeks ago

IF you are willing to work on this, you can first start with creating a game context module.

This body of work can be the first commit in your PR.

kuv2707 commented 3 weeks ago

It would be encouraged if you are open with any problems you face or something in the implementation or architecture you didn't understand - or some suggestion to improve/simplify things. These discussions can be done preferably on the whatsapp group (or sometimes DM)

Once you open a PR, further discussions can be done there. You can "review" your own code and comment on a block of code which warrants maintainers' attention.

PrathamX595 commented 3 weeks ago

@kuv2707 I would like to co contribute on this issue

kuv2707 commented 3 weeks ago

@PrathamX595 Please go ahead, for some reason i am not able to assign this

kuv2707 commented 3 weeks ago

ah done