search

shivaprsd / doqment

Mozilla's HTML5 PDF Viewer with Reader-mode add-on. šŸ“–
https://shivaprsd.github.io/doqment/src/pdfjs/web/viewer.html
MIT License
43 stars 1 forks source link

Added chromium note in README about opening pdf links #13

Closed notPlancha closed 8 months ago

notPlancha commented 9 months ago

It took me awhile to find out that chromium can just not skip the whole "reading the pdf" part and go straight to downloading them, and it seems some chromium browsers set "download PDFs" on by default (and even turn it on after removing pdf.js for some reason)

Feel free to rewrite the text (or deny the pull request if you think it's not the place), I just think it's useful information and wanted to share

shivaprsd commented 9 months ago

@notPlancha Thanks for being the first ever contributor to doqment. šŸ„‡

This is interesting, I never knew that Chrome had such a setting. A note on it is definitely useful, not only in the Readme, but also in the extension listing page in CWS.

I noticed that opening PDF links via the context menu is not affected by this setting (Iā€™m glad that I made that the primary method šŸ˜…). But disabling it does break functionality of the toolbar button, opening embedded PDFs, etc.

I think we should make these nuances clear in the note before merging.

shivaprsd commented 9 months ago

@notPlancha I have reworded the note. If it looks good to you, can we squash the three commits into one and force push?

shivaprsd commented 8 months ago

@notPlancha The original commit message had a typo, so I edited it.

Thanks for the contribution! šŸ™‚

P.S. when I did the rebase an unrelated commit got into this, no idea how, but doesn't matter. šŸ˜