Need to set PDF.js preferences

MagicalDrizzle commented 1 year ago

It seems that since pdf.js only honors prefers-color-scheme, setting privacy.resistFingerprinting = true will force it to be white, and people have been asking for a manual dark mode toggle for quite a while: https://github.com/mozilla/pdf.js/issues/12290

The official pdf.js team however seems to have made a pref specifically for this, but that doesn't apply to doqment for obvious reasons

Could a manual toggle be implemented?

shivaprsd commented 1 year ago

Thanks for pointing this out! I did know of that pref, but I did not know about privacy.resistFingerprinting and its effect on prefers-color-scheme.

I would be hard-pressed to implement a manual toggle; even the original maintainers could not find a way to modify the needed CSS dynamically – see https://github.com/mozilla/pdf.js/pull/12625#issue-743267748. 🙃

A wider-scoped workaround would be to provide an Options page to set the pref, as well as the other prefs. This has been wanting since v0.1 and I've been planning to add one on the lines of the PDF.js Chrome extension.

Will the Options page cover your use-case well enough? It would be quickly accessible, by right-clicking on the doqment button on the toolbar.

MagicalDrizzle commented 1 year ago

it'd definitely be good enough!

provide an Options page to set the pref, as well as the other prefs.

oh that was what I meant by "manual toggle" oops

also not having a toggle and having the dark theme only accessible by prefers-color-scheme is my biggest gripe of quite a few extensions that are like, out for my eyes (onetab being the biggest offender :p) that was not directed at you by any means btw

shivaprsd commented 1 year ago

Great!

oh that was what I meant by "manual toggle" oops

In the linked issue, somebody was asking for a manual toggle button on the toolbar itself, so I thought you meant that. 😅

~This should be ready by v0.3~.

shivaprsd commented 1 year ago

I am deferring this to a future release. The Options page would need some work, and I have other finished features to ship.

Meanwhile, you can always have a dark Reader theme even when the PDF.js toolbars and stuff are light. doqment's prefs are separate from PDF.js's, and they are directly set from the toolbar.

MagicalDrizzle commented 1 year ago

May I ask if you still have plan to work on this?

shivaprsd commented 1 year ago

@MagicalDrizzle Sorry about that! I'm sort of too busy to work on it at the moment. 😥

Meanwhile can you try the method given in https://github.com/shivaprsd/doqment/issues/5#issuecomment-1421103657? You'll have to execute something like:

PDFViewerApplication.preferences.set('viewerCssTheme', 2)    /* for dark */

It's not as convenient as an options page, still, better than nothing for the time being.

MagicalDrizzle commented 1 year ago

@shivaprsd It just returns a not defined error for me...

shivaprsd commented 1 year ago

@MagicalDrizzle Can you tell me what OS & browser you use and their versions? And also the version of doqment?

The code should be executed in the console opened for a doqment tab, with or without any PDF loaded. But I guess you are doing just that, looking at the screenshot. I am curious why it shouldn't work.

MagicalDrizzle commented 1 year ago

Windows 10 19045.2965, Firefox 114.0.1, doqment v0.4

MagicalDrizzle commented 1 year ago

@shivaprsd It seems it only works when you open the extension page itself (so address bar shows the "ugly" moz-extension url) If you paste it in a tab with something other than that (like when you paste the DOI in scihub) then it won't work (probably for obvious reasons) ugly

KiitoX commented 1 year ago

On that particular page (and many others), the pdf is shown inside an You can list these different frames, and select which you want to attach the console to in this menu: <img src="https://github.com/shivaprsd/doqment/assets/5896952/49ff5c93-2dfb-4b6f-8ec1-161fb995f1e4" alt="Screenshot_20230612_235232" /></p> <p>Edit: that button is only shown when there is <a href="https://firefox-source-docs.mozilla.org/devtools-user/working_with_iframes/index.html">at least one iframe present</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shivaprsd"><img src="https://avatars.githubusercontent.com/u/18247990?v=4" />shivaprsd</a> commented <strong> 1 year ago</strong> </div> <div class="markdown-body"> <blockquote> <p>On that particular page (and many others), the pdf is shown inside an <iframe></p> </blockquote> <p>@KiitoX I had suspected this. But I didn't know the button shows up only in pages with iframes. Thanks for clearing it up! </p> <blockquote> <p>It seems it only works when you open the extension page itself</p> </blockquote> <p>@MagicalDrizzle Yes, correct. Just execute it with the value <code>2</code> in the extension page and reload it. It will then start to apply everywhere automatically, including iframes, so you <em>don't</em> have to do it again for the other page.</p> <p>You can use the same command to revert it as well. The values are 0 = automatic (default), 1 = always light, 2 = always dark.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shivaprsd"><img src="https://avatars.githubusercontent.com/u/18247990?v=4" />shivaprsd</a> commented <strong> 6 months ago</strong> </div> <div class="markdown-body"> <p>The Options page is in the works, and should be ready by the next release. The progress can be tracked <a href="/shivaprsd/doqment/tree/options">here</a>.</p> <p>Currently it looks like this, embedded in Extension Settings in Firefox (feedback welcome): <img src="https://github.com/shivaprsd/doqment/assets/18247990/20b4c018-3abe-4b0e-92e6-60906d4c0763" alt="options-page" /></p> <p>The values are viewer defaults, but any overrides set via the console are respected; so migration won’t be a problem.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/MagicalDrizzle"><img src="https://avatars.githubusercontent.com/u/49761211?v=4" />MagicalDrizzle</a> commented <strong> 6 months ago</strong> </div> <div class="markdown-body"> <p>do your best! I will say this extension has basically saved my eyesights as I look at sci-hub all the time at 2am... I'm glad to be able to see it develop ^^</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/shivaprsd"><img src="https://avatars.githubusercontent.com/u/18247990?v=4" />shivaprsd</a> commented <strong> 6 months ago</strong> </div> <div class="markdown-body"> <p>@MagicalDrizzle Version 0.7 in now live in the Add-ons store.</p> <p>Happy New Year! 🎉 </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

shivaprsd / doqment

Need to set PDF.js preferences #2