search

shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application
MIT License
112 stars 30 forks source link

herrera-io/version is abandoned preRelease/build are truncated #27

Closed Toilal closed 7 years ago

Toilal commented 7 years ago

herrera-io/version is abandoned, and I have found an issue in this dependency.

Would you consider migrating to another dependency, maybe composer/semver would be a good choice ?

Problem is here : https://github.com/kherge-abandoned/php-version/blob/master/src/lib/Herrera/Version/Parser.php#L70 and https://github.com/kherge-abandoned/php-version/blob/master/src/lib/Herrera/Version/Parser.php#L76.

build and preRelease may be truncated if they contains + and -.

list($version, $build) = explode('+', $version);

should be replaced with

list($version, $build) = explode('+', $version, 2);
shivas commented 7 years ago

read below...

shivas commented 7 years ago

try: 2.0.0-alpha branch, it's alpha, but people report its working fine with new library, let me know if everything is fine with this branch, i may actually release 2.0.0 soon

Toilal commented 7 years ago

Yes, alpha branch is really better with the refactoring of Handler into Provider/Formatter.

I only have to define a null formatter to do exactly what I want (=raw git describe output). Do you plan a release on packagist soon ?

Thanks :+1: