shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application
MIT License
111 stars 30 forks source link

Symfony 4.4 / Twig 3 compatibility #62

Closed mikatrash closed 4 years ago

mikatrash commented 4 years ago

Hi,

We encountered this issue since we updated to SF4.4. Twig's GlobalInterface is TypeHinted (https://github.com/twigphp/Twig/commit/54cec4e3b8555fbb40c8dd7c6642e9f21607010d#diff-08b21707843379a1fde275ef7f0a2b49) so VersionExtension doesn't implement the interface.

Declaration of Shivas\VersioningBundle\Twig\VersionExtension::getGlobals() must be compatible with Twig\Extension\GlobalsInterface::getGlobals(): array in C:\WorkspacesEclipse\TRUNK\eLogikSupport\vendor\shivas\versioning-bundle\Twig\VersionExtension.php on line 12

dontub commented 4 years ago

Fixed by #63.