shivas / versioning-bundle

Simple way to version (semantic versioning 2.0.0) your Symfony2/3/4/5/6 application

MIT License

111 stars 30 forks source link

PHP8 compatibility #70

Closed Geekimo closed 3 years ago

Geekimo commented 3 years ago

PHP8 compatibility and Sf5 test

dontub commented 3 years ago

Thanks for the PR! I currently see two issues:

There are some jobs failing: https://travis-ci.org/github/shivas/versioning-bundle/builds/754022997
nikolaposa/version 3.2 is not marked as PHP 8 compatible.

Geekimo commented 3 years ago

Regarding nikolaposa's work, the latest version is php8 compatible, i'll update the composer.json

dontub commented 3 years ago

In #73 updating to nikolaposa/version 4 is WIP. I'd suggest to wait for this and afterwards add PHP 8 compatibility.

Geekimo commented 3 years ago

Hi @dontub , I was talking with this issue with my CTO this morning, as we are trying to go PHP8 for all our future developments, and many librairies, despite having php8 support in master branch doesn't have tagged it yet.

Thanks for the feedback tho.

xvilo commented 3 years ago

It would be great if this could already be merged as it will allow possibly faster compatibility

Geekimo commented 3 years ago

73 is way more advanced than mine.